Commit 5c692cb
doc: fix import.meta example for vm.SourceTextModule
The import.meta example for new vm.SourceTextModule() in vm.md does not
run as written. It fails in two separate ways.
First, the constructor is missing the context: contextifiedObject
option, so the module evaluates in the top context where secret is not
defined, and the snippet throws ReferenceError: secret is not defined.
Second, the trailing note suggests replacing meta.prop = {} with
vm.runInContext('{}', contextifiedObject), but '{}' is parsed as an
empty block and evaluates to undefined. That makes the following
Object.getPrototypeOf(import.meta.prop) throw TypeError. Wrapping it as
'({})' returns an object, which is what the note intends.
This adds the context option and corrects the suggested replacement to
'({})' in both the mjs and cjs variants.
Fixes: #64076
Signed-off-by: Muhammad Zeeshan <61280174+zeeshan56656@users.noreply.github.com>
PR-URL: #64112
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 7568ce7 commit 5c692cb
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -919,6 +919,7 @@ const contextifiedObject = vm.createContext({ secret: 42 }); | |||
| 919 | 919 | const module = new vm.SourceTextModule( | |
| 920 | 920 | 'Object.getPrototypeOf(import.meta.prop).secret = secret;', | |
| 921 | 921 | { | |
| 922 | + context: contextifiedObject, | ||
| 922 | 923 | initializeImportMeta(meta) { | |
| 923 | 924 | // Note: this object is created in the top context. As such, | |
| 924 | 925 | // Object.getPrototypeOf(import.meta.prop) points to the | |
@@ -937,7 +938,7 @@ await module.evaluate(); | |||
| 937 | 938 | // To fix this problem, replace | |
| 938 | 939 | // meta.prop = {}; | |
| 939 | 940 | // above with | |
| 940 | - // meta.prop = vm.runInContext('{}', contextifiedObject); | ||
| 941 | + // meta.prop = vm.runInContext('({})', contextifiedObject); | ||
| 941 | 942 | ``` | |
| 942 | 943 | ||
| 943 | 944 | ```cjs | |
@@ -947,6 +948,7 @@ const contextifiedObject = vm.createContext({ secret: 42 }); | |||
| 947 | 948 | const module = new vm.SourceTextModule( | |
| 948 | 949 | 'Object.getPrototypeOf(import.meta.prop).secret = secret;', | |
| 949 | 950 | { | |
| 951 | + context: contextifiedObject, | ||
| 950 | 952 | initializeImportMeta(meta) { | |
| 951 | 953 | // Note: this object is created in the top context. As such, | |
| 952 | 954 | // Object.getPrototypeOf(import.meta.prop) points to the | |
@@ -964,7 +966,7 @@ const contextifiedObject = vm.createContext({ secret: 42 }); | |||
| 964 | 966 | // To fix this problem, replace | |
| 965 | 967 | // meta.prop = {}; | |
| 966 | 968 | // above with | |
| 967 | - // meta.prop = vm.runInContext('{}', contextifiedObject); | ||
| 969 | + // meta.prop = vm.runInContext('({})', contextifiedObject); | ||
| 968 | 970 | })(); | |
| 969 | 971 | ``` | |
| 970 | 972 | ||
0 commit comments