quic: fix broken listEndpoints export, test callbacks & nghttp3 include · nodejs/node@5ca7ef3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5ca7ef3

Browse filesBrowse the repository at this point in the historyBrowse files

pimterry

authored and

aduh95

committed

quic: fix broken listEndpoints export, test callbacks & nghttp3 include

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #63874 Backport-PR-URL: #64675 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 147150c commit 5ca7ef3
Copy full SHA for 5ca7ef3

3 files changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • quic.js
• src/quic
  • http3.cc
• test/parallel
  • test-quic-internal-setcallbacks.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/quic.js‎

Copy file name to clipboardExpand all lines: lib/quic.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -8,6 +8,7 @@ emitExperimentalWarning('quic');
8	8	const {
9	9	connect,
10	10	listen,
	11	+ listEndpoints,
11	12	QuicEndpoint,
12	13	QuicError,
13	14	QuicSession,
@@ -34,6 +35,7 @@ const constants = {
34	35	module.exports = {
35	36	connect,
36	37	listen,
	38	+ listEndpoints,
37	39	QuicEndpoint,
38	40	QuicError,
39	41	QuicSession,

Collapse file

‎src/quic/http3.cc‎

Copy file name to clipboardExpand all lines: src/quic/http3.cc

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,4 +1,3 @@
1		- #include "nghttp3/lib/nghttp3_conn.h"
2	1	#if HAVE_OPENSSL && HAVE_QUIC
3	2	#include "guard.h"
4	3	#ifndef OPENSSL_NO_QUIC

Collapse file

‎test/parallel/test-quic-internal-setcallbacks.mjs‎

Copy file name to clipboardExpand all lines: test/parallel/test-quic-internal-setcallbacks.mjs

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -15,6 +15,7 @@ const callbacks = {
15	15	onEndpointClose() {},
16	16	onSessionNew() {},
17	17	onSessionClose() {},
	18	+ onSessionApplication() {},
18	19	onSessionDatagram() {},
19	20	onSessionDatagramStatus() {},
20	21	onSessionHandshake() {},

0 commit comments

Comments

0 (0)