Commit 5cc24e6
deps: V8: cherry-pick 9a607043cb31
Original commit message:
[compiler] Gracefully handle an unsupported situation
... by skipping the optimization instead of CHECK-failing.
Bug: v8:12188
Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76741}
Refs: v8/v8@9a60704
PR-URL: #40046
Fixes: #40030
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 8de5eb8 commit 5cc24e6
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.10', | ||
| 39 | + 'v8_embedder_string': '-node.11', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1527,8 +1527,8 @@ base::Optional<PropertyCell> ConcurrentLookupIterator::TryGetPropertyCell( | |||
| 1527 | 1527 | DisallowGarbageCollection no_gc; | |
| 1528 | 1528 | ||
| 1529 | 1529 | Map holder_map = holder->map(); | |
| 1530 | - CHECK(!holder_map.is_access_check_needed()); | ||
| 1531 | - CHECK(!holder_map.has_named_interceptor()); | ||
| 1530 | + if (holder_map.is_access_check_needed()) return {}; | ||
| 1531 | + if (holder_map.has_named_interceptor()) return {}; | ||
| 1532 | 1532 | ||
| 1533 | 1533 | GlobalDictionary dict = holder->global_dictionary(kAcquireLoad); | |
| 1534 | 1534 | base::Optional<PropertyCell> cell = | |
0 commit comments