Commit 5cfab14
test: remove common.hasTracing
`common.hasTracing` is only used in one place. `common` is bloated so
let's move that to the one test that uses it.
`hasTracing` is undocumented so there's no need to remove it from the
README file as it's not there in the first place.
Similarly, it's not included in the .mjs version of the `common` file.
PR-URL: #22250
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 03b8258 commit 5cfab14
2 files changed
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,6 @@ const { exec, execSync, spawn, spawnSync } = require('child_process'); | |||
| 30 | 30 | const stream = require('stream'); | |
| 31 | 31 | const util = require('util'); | |
| 32 | 32 | const Timer = process.binding('timer_wrap').Timer; | |
| 33 | - const { hasTracing } = process.binding('config'); | ||
| 34 | 33 | const { fixturesDir } = require('./fixtures'); | |
| 35 | 34 | const tmpdir = require('./tmpdir'); | |
| 36 | 35 | ||
@@ -227,12 +226,6 @@ Object.defineProperty(exports, 'hasCrypto', { | |||
| 227 | 226 | } | |
| 228 | 227 | }); | |
| 229 | 228 | ||
| 230 | - Object.defineProperty(exports, 'hasTracing', { | ||
| 231 | - get: function() { | ||
| 232 | - return Boolean(hasTracing); | ||
| 233 | - } | ||
| 234 | - }); | ||
| 235 | - | ||
| 236 | 229 | Object.defineProperty(exports, 'hasFipsCrypto', { | |
| 237 | 230 | get: function() { | |
| 238 | 231 | return exports.hasCrypto && require('crypto').fips; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,7 @@ | |||
| 3 | 3 | ||
| 4 | 4 | const common = require('../common'); | |
| 5 | 5 | ||
| 6 | - if (!common.hasTracing) | ||
| 6 | + if (!process.binding('config').hasTracing) | ||
| 7 | 7 | common.skip('missing trace events'); | |
| 8 | 8 | if (!common.isMainThread) | |
| 9 | 9 | common.skip('process.chdir is not available in Workers'); | |
0 commit comments