lib: replace Symbol.asyncIterator by SymbolAsyncIterator · nodejs/node@5cfcf6f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5cfcf6f

Browse filesBrowse the repository at this point in the historyBrowse files

Sebastien-Ahkrin

authored and

targos

committed

lib: replace Symbol.asyncIterator by SymbolAsyncIterator

PR-URL: #30947 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 31227e6 commit 5cfcf6f
Copy full SHA for 5cfcf6f

4 files changed

+10-8Lines changed: 10 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _stream_readable.js
  • internal
    • fs
      • dir.js
    • streams
      • from.js
  • readline.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_stream_readable.js‎

Copy file name to clipboardExpand all lines: lib/_stream_readable.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,7 @@ const {
27	27	NumberIsNaN,
28	28	ObjectDefineProperty,
29	29	ObjectSetPrototypeOf,
30		- Symbol,
	30	+ SymbolAsyncIterator,
31	31	} = primordials;
32	32
33	33	module.exports = Readable;
@@ -1073,7 +1073,7 @@ Readable.prototype.wrap = function(stream) {
1073	1073	return this;
1074	1074	};
1075	1075
1076		- Readable.prototype[Symbol.asyncIterator] = function() {
	1076	+ Readable.prototype[SymbolAsyncIterator] = function() {
1077	1077	if (createReadableStreamAsyncIterator === undefined) {
1078	1078	createReadableStreamAsyncIterator =
1079	1079	require('internal/streams/async_iterator');

Collapse file

‎lib/internal/fs/dir.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/dir.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3,6 +3,7 @@
3	3	const {
4	4	ObjectDefineProperty,
5	5	Symbol,
	6	+ SymbolAsyncIterator,
6	7	} = primordials;
7	8
8	9	const pathModule = require('path');
@@ -175,7 +176,7 @@ class Dir {
175	176	}
176	177	}
177	178
178		- ObjectDefineProperty(Dir.prototype, Symbol.asyncIterator, {
	179	+ ObjectDefineProperty(Dir.prototype, SymbolAsyncIterator, {
179	180	value: Dir.prototype.entries,
180	181	enumerable: false,
181	182	writable: true,

Collapse file

‎lib/internal/streams/from.js‎

Copy file name to clipboardExpand all lines: lib/internal/streams/from.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,7 @@
1	1	'use strict';
2	2
3	3	const {
4		- Symbol,
	4	+ SymbolAsyncIterator,
5	5	SymbolIterator
6	6	} = primordials;
7	7
@@ -11,8 +11,8 @@ const {
11	11
12	12	function from(Readable, iterable, opts) {
13	13	let iterator;
14		- if (iterable && iterable[Symbol.asyncIterator])
15		- iterator = iterable[Symbol.asyncIterator]();
	14	+ if (iterable && iterable[SymbolAsyncIterator])
	15	+ iterator = iterable[SymbolAsyncIterator]();
16	16	else if (iterable && iterable[SymbolIterator])
17	17	iterator = iterable[SymbolIterator]();
18	18	else

Collapse file

‎lib/readline.js‎

Copy file name to clipboardExpand all lines: lib/readline.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -37,6 +37,7 @@ const {
37	37	ObjectDefineProperty,
38	38	ObjectSetPrototypeOf,
39	39	Symbol,
	40	+ SymbolAsyncIterator,
40	41	} = primordials;
41	42
42	43	const {
@@ -1088,7 +1089,7 @@ Interface.prototype._ttyWrite = function(s, key) {
1088	1089	}
1089	1090	};
1090	1091
1091		- Interface.prototype[Symbol.asyncIterator] = function() {
	1092	+ Interface.prototype[SymbolAsyncIterator] = function() {
1092	1093	if (this[kLineObjectStream] === undefined) {
1093	1094	if (Readable === undefined) {
1094	1095	Readable = require('stream').Readable;
@@ -1118,7 +1119,7 @@ Interface.prototype[Symbol.asyncIterator] = function() {
1118	1119	this[kLineObjectStream] = readable;
1119	1120	}
1120	1121
1121		- return this[kLineObjectStream][Symbol.asyncIterator]();
	1122	+ return this[kLineObjectStream][SymbolAsyncIterator]();
1122	1123	};
1123	1124
1124	1125	/**

0 commit comments

Comments

0 (0)