Commit 5d1463a
build: define HAVE_OPENSSL macro for cctest
cctest build target wasn't defining the HAVE_OPENSSL macro when
node_use_openssl was true, causing inconsistencies on most
`node::Environment` member's addresses. For example, if someone
wanted to access the context of an environment by using
`node::Environment::context()`, the object returned by the
function was pointing to an invalid address.
PR-URL: #17461
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent c951e2c commit 5d1463a
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -859,6 +859,9 @@ | |||
| 859 | 859 | '<(OBJ_PATH)<(OBJ_SEPARATOR)node_crypto_clienthello.<(OBJ_SUFFIX)', | |
| 860 | 860 | '<(OBJ_PATH)<(OBJ_SEPARATOR)tls_wrap.<(OBJ_SUFFIX)', | |
| 861 | 861 | ], | |
| 862 | + 'defines': [ | ||
| 863 | + 'HAVE_OPENSSL=1', | ||
| 864 | + ], | ||
| 862 | 865 | }], | |
| 863 | 866 | ['v8_enable_inspector==1', { | |
| 864 | 867 | 'sources': [ | |
0 commit comments