test: improve error emssage reporting in testNapiRun.js · nodejs/node@5d3a4ad · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5d3a4ad

Browse filesBrowse the repository at this point in the historyBrowse files

Paul Ashfield

authored and

evanlucas

committed

test: improve error emssage reporting in testNapiRun.js

PR-URL: #16821 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

1 parent f71f41d commit 5d3a4ad
Copy full SHA for 5d3a4ad

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/addons-napi/test_general
  • testNapiRun.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/addons-napi/test_general/testNapiRun.js‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_general/testNapiRun.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -7,6 +7,9 @@ const assert = require('assert');
7	7	// eslint-disable-next-line no-unused-vars
8	8	const addon = require(`./build/${common.buildType}/test_general`);
9	9
10		- assert.strictEqual(addon.testNapiRun('(41.92 + 0.08);'), 42,
11		- 'napi_run_script() works correctly');
	10	+ const testCase = '(41.92 + 0.08);';
	11	+ const expected = 42;
	12	+ const actual = addon.testNapiRun(testCase);
	13	+
	14	+ assert.strictEqual(actual, expected);
12	15	assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/);

0 commit comments

Comments

0 (0)