Commit 5deafc1
build,win: improve logs when ClangCL is missing
PR-URL: #61438
Fixes: #61437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 8a43244 commit 5deafc1
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -247,7 +247,7 @@ call :getnodeversion || exit /b 1 | |||
| 247 | 247 | set NODE_MAJOR_VERSION= | |
| 248 | 248 | for /F "tokens=1 delims=." %%i in ("%NODE_VERSION%") do set "NODE_MAJOR_VERSION=%%i" | |
| 249 | 249 | if %NODE_MAJOR_VERSION% GEQ 24 ( | |
| 250 | - echo Using ClangCL because the Node.js version being compiled is ^>= 24. | ||
| 250 | + echo ClangCL is required because the Node.js version being compiled is ^>= 24. | ||
| 251 | 251 | set clang_cl=1 | |
| 252 | 252 | ) | |
| 253 | 253 | ||
@@ -298,7 +298,7 @@ goto msbuild-found | |||
| 298 | 298 | ||
| 299 | 299 | :msbuild-not-found | |
| 300 | 300 | set "clang_echo=" | |
| 301 | - if defined clang_cl set "clang_echo= or Clang compiler/LLVM toolset" | ||
| 301 | + if defined clang_cl set "clang_echo= with Clang compiler/LLVM toolset" | ||
| 302 | 302 | echo Failed to find a suitable Visual Studio installation%clang_echo%. | |
| 303 | 303 | echo Try to run in a "Developer Command Prompt" or consult | |
| 304 | 304 | echo https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows | |
0 commit comments