test: skip whatwg url parse and setter tests when icu is missing · nodejs/node@5e138fe · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5e138fe

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

evanlucas

committed

test: skip whatwg url parse and setter tests when icu is missing

the WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse and setter tests if ICU is not present. PR-URL: #9246 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

1 parent a39b98e commit 5e138fe
Copy full SHA for 5e138fe

2 files changed

+14Lines changed: 14 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-whatwg-url-parsing.js
  • test-whatwg-url-setters.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-whatwg-url-parsing.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-url-parsing.js

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,13 @@
1	1	'use strict';
2	2
3	3	const common = require('../common');
	4	+
	5	+ if (!common.hasIntl) {
	6	+ // A handful of the tests fail when ICU is not included.
	7	+ common.skip('missing Intl... skipping test');
	8	+ return;
	9	+ }
	10	+
4	11	const URL = require('url').URL;
5	12	const path = require('path');
6	13	const assert = require('assert');

Collapse file

‎test/parallel/test-whatwg-url-setters.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-url-setters.js

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,13 @@
1	1	'use strict';
2	2
3	3	const common = require('../common');
	4	+
	5	+ if (!common.hasIntl) {
	6	+ // A handful of the tests fail when ICU is not included.
	7	+ common.skip('missing Intl... skipping test');
	8	+ return;
	9	+ }
	10	+
4	11	const path = require('path');
5	12	const URL = require('url').URL;
6	13	const assert = require('assert');

0 commit comments

Comments

0 (0)