Commit 5e1ceaa
build: remove redundant Makefile target
The only target that uses the
`tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a
result of a recent change, it has `tools/doc/node_modules` as a
prerequisite, which does the exact same npm install as
`tools/doc/node_modules/js-yaml/package.json`. Remove
`tools/doc/node_modules/js-yaml/package.json` as unnecessary.
PR-URL: #21915
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 3213c09 commit 5e1ceaa
1 file changed
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -619,11 +619,6 @@ apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_as | |||
| 619 | 619 | .PHONY: doc-only | |
| 620 | 620 | doc-only: tools/doc/node_modules \ | |
| 621 | 621 | $(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary. | |
| 622 | - # If it's a source tarball, assets are already in doc/api/assets, | ||
| 623 | - # no need to install anything, we have already copied the docs over | ||
| 624 | - if [ ! -d doc/api/assets ]; then \ | ||
| 625 | - $(MAKE) tools/doc/node_modules/js-yaml/package.json; \ | ||
| 626 | - fi; | ||
| 627 | 622 | @$(MAKE) out/doc/api/all.html out/doc/api/all.json | |
| 628 | 623 | ||
| 629 | 624 | .PHONY: doc | |
@@ -662,9 +657,6 @@ available-node = \ | |||
| 662 | 657 | run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock | |
| 663 | 658 | run-npm-ci = $(PWD)/$(NPM) ci | |
| 664 | 659 | ||
| 665 | - tools/doc/node_modules/js-yaml/package.json: | ||
| 666 | - cd tools/doc && $(call available-node,$(run-npm-install)) | ||
| 667 | - | ||
| 668 | 660 | gen-json = tools/doc/generate.js --format=json $< > $@ | |
| 669 | 661 | gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \ | |
| 670 | 662 | --analytics=$(DOCS_ANALYTICS) $< > $@ | |
0 commit comments