Commit 5e90fc6
fs: use fs.access in fs.exists
Uses fs.access to implement fs.exists functionality. Fixes a issue,
when a file exists but user does not have privileges to do stat on the
file.
Fixes: #17921
Backport-PR-URL: #19654
PR-URL: #18618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ae86adc commit 5e90fc6
1 file changed
Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -323,12 +323,7 @@ fs.accessSync = function(path, mode) { | |||
| 323 | 323 | }; | |
| 324 | 324 | ||
| 325 | 325 | fs.exists = function(path, callback) { | |
| 326 | - if (handleError((path = getPathFromURL(path)), cb)) | ||
| 327 | - return; | ||
| 328 | - if (!nullCheck(path, cb)) return; | ||
| 329 | - var req = new FSReqWrap(); | ||
| 330 | - req.oncomplete = cb; | ||
| 331 | - binding.stat(pathModule.toNamespacedPath(path), req); | ||
| 326 | + fs.access(path, fs.F_OK, cb); | ||
| 332 | 327 | function cb(err) { | |
| 333 | 328 | if (callback) callback(err ? false : true); | |
| 334 | 329 | } | |
@@ -345,9 +340,7 @@ Object.defineProperty(fs.exists, internalUtil.promisify.custom, { | |||
| 345 | 340 | ||
| 346 | 341 | fs.existsSync = function(path) { | |
| 347 | 342 | try { | |
| 348 | - handleError((path = getPathFromURL(path))); | ||
| 349 | - nullCheck(path); | ||
| 350 | - binding.stat(pathModule.toNamespacedPath(path)); | ||
| 343 | + fs.accessSync(path, fs.F_OK); | ||
| 351 | 344 | return true; | |
| 352 | 345 | } catch (e) { | |
| 353 | 346 | return false; | |
0 commit comments