| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent fb3af1b commit 5eafe3b
2 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -123,7 +123,8 @@ function handledRejection(promise) { | |||
| 123 | 123 | return; | |
| 124 | 124 | } | |
| 125 | 125 | } | |
| 126 | - setHasRejectionToWarn(false); | ||
| 126 | + if (maybeUnhandledPromises.size === 0 && asyncHandledRejections.length === 0) | ||
| 127 | + setHasRejectionToWarn(false); | ||
| 127 | 128 | } | |
| 128 | 129 | ||
| 129 | 130 | const unhandledRejectionErrName = 'UnhandledPromiseRejectionWarning'; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -718,3 +718,15 @@ asyncTest( | |||
| 718 | 718 | let timer = setTimeout(common.mustNotCall(), 10000); | |
| 719 | 719 | }, | |
| 720 | 720 | ); | |
| 721 | + | ||
| 722 | + // https://github.com/nodejs/node/issues/30953 | ||
| 723 | + asyncTest( | ||
| 724 | + 'Catching a promise should not take effect on previous promises', | ||
| 725 | + function(done) { | ||
| 726 | + onUnhandledSucceed(done, function(reason, promise) { | ||
| 727 | + assert.strictEqual(reason, '1'); | ||
| 728 | + }); | ||
| 729 | + Promise.reject('1'); | ||
| 730 | + Promise.reject('2').catch(function() {}); | ||
| 731 | + } | ||
| 732 | + ); | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments