test: add more logs to test-esm-loader-hooks-inspect-wait · nodejs/node@5efe4f7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5efe4f7

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

aduh95

committed

test: add more logs to test-esm-loader-hooks-inspect-wait

This provides a bit more information about where & when the child processes crashes when it crashes / flakes in the CI. PR-URL: #60466 Refs: #54346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent 2a57268 commit 5efe4f7
Copy full SHA for 5efe4f7

1 file changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-esm-loader-hooks-inspect-wait.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-esm-loader-hooks-inspect-wait.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-esm-loader-hooks-inspect-wait.js

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -12,6 +12,7 @@ const { NodeInstance } = require('../common/inspector-helper.js');
12	12
13	13	async function runTest() {
14	14	const main = fixtures.path('es-module-loaders', 'register-loader.mjs');
	15	+ process.env.NODE_DEBUG = 'esm,async_loader_worker';
15	16	const child = new NodeInstance(['--inspect-wait=0'], '', main);
16	17
17	18	const session = await child.connectInspectorSession();
@@ -24,7 +25,11 @@ async function runTest() {
24	25	]);
25	26	await session.send({ method: 'NodeRuntime.disable' });
26	27	await session.waitForDisconnect();
27		- assert.strictEqual((await child.expectShutdown()).exitCode, 0);
	28	+ const result = await child.expectShutdown();
	29	+ assert.deepStrictEqual(result, {
	30	+ exitCode: 0,
	31	+ signal: null,
	32	+ });
28	33	}
29	34
30	35	runTest();

0 commit comments

Comments

0 (0)