bootstrap: include event_target into the built-in snapshot · nodejs/node@5f37dec · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5f37dec

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

bootstrap: include event_target into the built-in snapshot

Since the module has to be loaded during bootstrap anyway. PR-URL: #45849 Backport-PR-URL: #46425 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent c3f56a3 commit 5f37dec
Copy full SHA for 5f37dec

2 files changed

+8-3Lines changed: 8 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • browser.js
• test/parallel
  • test-bootstrap-modules.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/browser.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/browser.js

+5-3Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -42,9 +42,11 @@ defineOperation(globalThis, 'setTimeout', timers.setTimeout);
42	42	exposeLazyInterfaces(globalThis, 'internal/abort_controller', [
43	43	'AbortController', 'AbortSignal',
44	44	]);
45		- exposeLazyInterfaces(globalThis, 'internal/event_target', [
46		- 'EventTarget', 'Event',
47		- ]);
	45	+ const {
	46	+ EventTarget, Event,
	47	+ } = require('internal/event_target');
	48	+ exposeInterface(globalThis, 'Event', Event);
	49	+ exposeInterface(globalThis, 'EventTarget', EventTarget);
48	50	exposeLazyInterfaces(globalThis, 'internal/worker/io', [
49	51	'MessageChannel', 'MessagePort', 'MessageEvent',
50	52	]);

Collapse file

‎test/parallel/test-bootstrap-modules.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-bootstrap-modules.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -46,6 +46,7 @@ const expectedModules = new Set([
46	46	'NativeModule internal/constants',
47	47	'NativeModule internal/dns/utils',
48	48	'NativeModule internal/errors',
	49	+ 'NativeModule internal/event_target',
49	50	'NativeModule internal/fixed_queue',
50	51	'NativeModule internal/fs/utils',
51	52	'NativeModule internal/idna',
@@ -90,6 +91,7 @@ const expectedModules = new Set([
90	91	'NativeModule internal/vm',
91	92	'NativeModule internal/vm/module',
92	93	'NativeModule internal/wasm_web_api',
	94	+ 'NativeModule internal/webidl',
93	95	'NativeModule internal/worker/js_transferable',
94	96	'Internal Binding blob',
95	97	'NativeModule async_hooks',
@@ -99,6 +101,7 @@ const expectedModules = new Set([
99	101	'NativeModule url',
100	102	'NativeModule internal/v8/startup_snapshot',
101	103	'NativeModule vm',
	104	+ 'NativeModule util',
102	105	]);
103	106
104	107	if (!common.isMainThread) {

0 commit comments

Comments

0 (0)