test: assert: fix deepStrictEqual comparing a real array and fake array · nodejs/node@5f42b1f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5f42b1f

Browse filesBrowse the repository at this point in the historyBrowse files

ljharb

authored and

MylesBorins

committed

test: assert: fix deepStrictEqual comparing a real array and fake array

PR-URL: #30743 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent 9d1c793 commit 5f42b1f
Copy full SHA for 5f42b1f

1 file changed

+15Lines changed: 15 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-assert-deep.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-assert-deep.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert-deep.js

+15Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1043,6 +1043,21 @@ assert.throws(
1043	1043	assertDeepAndStrictEqual(a, b);
1044	1044	}
1045	1045
	1046	+ // Verify that an array and the equivalent fake array object
	1047	+ // are correctly compared
	1048	+ {
	1049	+ const a = [1, 2, 3];
	1050	+ const o = {
	1051	+ __proto__: Array.prototype,
	1052	+ 0: 1,
	1053	+ 1: 2,
	1054	+ 2: 3,
	1055	+ length: 3,
	1056	+ };
	1057	+ Object.defineProperty(o, 'length', { enumerable: false });
	1058	+ assertNotDeepOrStrict(o, a);
	1059	+ }
	1060	+
1046	1061	// Verify that extra keys will be tested for when using fake arrays.
1047	1062	{
1048	1063	const a = {

0 commit comments

Comments

0 (0)