Commit 5f44ce8
committed
deps: backport String::Utf8Length with isolate
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.
Refs: v8/v8@3dd5c6f
PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 8375f75 commit 5f44ce8
3 files changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -29,7 +29,7 @@ | |||
| 29 | 29 | ||
| 30 | 30 | # Reset this number to 0 on major V8 upgrades. | |
| 31 | 31 | # Increment by one for each non-official patch applied to deps/v8. | |
| 32 | - 'v8_embedder_string': '-node.21', | ||
| 32 | + 'v8_embedder_string': '-node.22', | ||
| 33 | 33 | ||
| 34 | 34 | # Enable disassembler for `--print-code` v8 options | |
| 35 | 35 | 'v8_enable_disassembler': 1, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2580,7 +2580,9 @@ class V8_EXPORT String : public Name { | |||
| 2580 | 2580 | * Returns the number of bytes in the UTF-8 encoded | |
| 2581 | 2581 | * representation of this string. | |
| 2582 | 2582 | */ | |
| 2583 | - int Utf8Length() const; | ||
| 2583 | + V8_DEPRECATE_SOON("Use Isolate version instead", int Utf8Length() const); | ||
| 2584 | + | ||
| 2585 | + int Utf8Length(Isolate* isolate) const; | ||
| 2584 | 2586 | ||
| 2585 | 2587 | /** | |
| 2586 | 2588 | * Returns whether this string is known to contain only one byte data, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5476,6 +5476,9 @@ bool String::ContainsOnlyOneByte() const { | |||
| 5476 | 5476 | return helper.Check(*str); | |
| 5477 | 5477 | } | |
| 5478 | 5478 | ||
| 5479 | + int String::Utf8Length(Isolate* isolate) const { | ||
| 5480 | + return Utf8Length(); | ||
| 5481 | + } | ||
| 5479 | 5482 | ||
| 5480 | 5483 | int String::Utf8Length() const { | |
| 5481 | 5484 | i::Handle<i::String> str = Utils::OpenHandle(this); | |
0 commit comments