Commit 5f928a8
test: increase querystring coverage
PR-URL: #12163
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 7af8738 commit 5f928a8
2 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,6 +9,11 @@ assert.deepStrictEqual(qs.escape('test'), 'test'); | |||
| 9 | 9 | assert.deepStrictEqual(qs.escape({}), '%5Bobject%20Object%5D'); | |
| 10 | 10 | assert.deepStrictEqual(qs.escape([5, 10]), '5%2C10'); | |
| 11 | 11 | assert.deepStrictEqual(qs.escape('Ŋōđĕ'), '%C5%8A%C5%8D%C4%91%C4%95'); | |
| 12 | + assert.deepStrictEqual(qs.escape('testŊōđĕ'), 'test%C5%8A%C5%8D%C4%91%C4%95'); | ||
| 13 | + assert.deepStrictEqual(qs.escape(`${String.fromCharCode(0xD800 + 1)}test`), | ||
| 14 | + '%F0%90%91%B4est'); | ||
| 15 | + assert.throws(() => qs.escape(String.fromCharCode(0xD800 + 1)), | ||
| 16 | + /^URIError: URI malformed$/); | ||
| 12 | 17 | ||
| 13 | 18 | // using toString for objects | |
| 14 | 19 | assert.strictEqual( | |
@@ -17,9 +22,11 @@ assert.strictEqual( | |||
| 17 | 22 | ); | |
| 18 | 23 | ||
| 19 | 24 | // toString is not callable, must throw an error | |
| 20 | - assert.throws(() => qs.escape({toString: 5})); | ||
| 25 | + assert.throws(() => qs.escape({toString: 5}), | ||
| 26 | + /^TypeError: Cannot convert object to primitive value$/); | ||
| 21 | 27 | ||
| 22 | 28 | // should use valueOf instead of non-callable toString | |
| 23 | 29 | assert.strictEqual(qs.escape({toString: 5, valueOf: () => 'test'}), 'test'); | |
| 24 | 30 | ||
| 25 | - assert.throws(() => qs.escape(Symbol('test'))); | ||
| 31 | + assert.throws(() => qs.escape(Symbol('test')), | ||
| 32 | + /^TypeError: Cannot convert a Symbol value to a string$/); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -308,6 +308,8 @@ function demoDecode(str) { | |||
| 308 | 308 | } | |
| 309 | 309 | check(qs.parse('a=a&b=b&c=c', null, null, { decodeURIComponent: demoDecode }), | |
| 310 | 310 | { aa: 'aa', bb: 'bb', cc: 'cc' }); | |
| 311 | + check(qs.parse('a=a&b=b&c=c', null, '==', { decodeURIComponent: (str) => str }), | ||
| 312 | + { 'a=a': '', 'b=b': '', 'c=c': '' }); | ||
| 311 | 313 | ||
| 312 | 314 | // Test QueryString.unescape | |
| 313 | 315 | function errDecode(str) { | |
0 commit comments