lib: fix stack overflow check to not break on primitives · nodejs/node@5f9ee9f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5f9ee9f

Browse filesBrowse the repository at this point in the historyBrowse files

kball

authored and

targos

committed

lib: fix stack overflow check to not break on primitives

PR-URL: #28338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent 937afcc commit 5f9ee9f
Copy full SHA for 5f9ee9f

2 files changed

+15-1Lines changed: 15 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • errors.js
• test/parallel
  • test-console-log-throw-primitive.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/errors.js‎

Copy file name to clipboardExpand all lines: lib/internal/errors.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -582,7 +582,7 @@ function isStackOverflowError(err) {
582	582	}
583	583	}
584	584
585		- return err.name === maxStack_ErrorName &&
	585	+ return err && err.name === maxStack_ErrorName &&
586	586	err.message === maxStack_ErrorMessage;
587	587	}
588	588

Collapse file

‎test/parallel/test-console-log-throw-primitive.js‎

Copy file name to clipboard

+14Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,14 @@
	1	+ 'use strict';
	2	+ require('../common');
	3	+ const { Writable } = require('stream');
	4	+ const { Console } = require('console');
	5	+
	6	+ const stream = new Writable({
	7	+ write() {
	8	+ throw null; // eslint-disable-line no-throw-literal
	9	+ }
	10	+ });
	11	+
	12	+ const console = new Console({ stdout: stream });
	13	+
	14	+ console.log('test'); // Should not throw

0 commit comments

Comments

0 (0)