Commit 5fe5fa2
test: make addon testing part of make test
Otherwise it's too easy to miss breaking changes to node.h and other
public headers until the CI catches them. `vcbuild test` tests addons
so there is precedence.
PR-URL: #6232
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>1 parent 457d12a commit 5fe5fa2
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -114,9 +114,9 @@ v8: | |||
| 114 | 114 | tools/make-v8.sh v8 | |
| 115 | 115 | $(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS) | |
| 116 | 116 | ||
| 117 | - test: | cctest # Depends on 'all'. | ||
| 117 | + test: | build-addons cctest # Both targets depend on 'all'. | ||
| 118 | 118 | $(PYTHON) tools/test.py --mode=release -J \ | |
| 119 | - doctool message parallel sequential | ||
| 119 | + addon doctool message parallel sequential | ||
| 120 | 120 | $(MAKE) lint | |
| 121 | 121 | ||
| 122 | 122 | test-parallel: all | |
@@ -141,7 +141,10 @@ ADDONS_BINDING_GYPS := \ | |||
| 141 | 141 | $(wildcard test/addons/*/binding.gyp)) | |
| 142 | 142 | ||
| 143 | 143 | # Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale. | |
| 144 | - test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp | ||
| 144 | + test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \ | ||
| 145 | + deps/uv/include/*.h deps/v8/include/*.h \ | ||
| 146 | + src/node.h src/node_buffer.h src/node_object_wrap.h \ | ||
| 147 | + | test/addons/.docbuildstamp | ||
| 145 | 148 | # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | |
| 146 | 149 | # embedded addons have been generated from the documentation. | |
| 147 | 150 | for dirname in test/addons/*/; do \ | |
0 commit comments