v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor · nodejs/node@606523d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 606523d

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

targos

committed

v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor

PR-URL: #47721 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent e948bec commit 606523d
Copy full SHA for 606523d

3 files changed

+35-2Lines changed: 35 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/v8
  • startup_snapshot.js
• test
  • fixtures/snapshot
    • v8-startup-snapshot-api.js
  • parallel
    • test-v8-startup-snapshot-api.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/v8/startup_snapshot.js‎

Copy file name to clipboardExpand all lines: lib/internal/v8/startup_snapshot.js

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -4,8 +4,10 @@ const {
4	4	validateFunction,
5	5	} = require('internal/validators');
6	6	const {
7		- ERR_NOT_BUILDING_SNAPSHOT,
8		- ERR_DUPLICATE_STARTUP_SNAPSHOT_MAIN_FUNCTION,
	7	+ codes: {
	8	+ ERR_NOT_BUILDING_SNAPSHOT,
	9	+ ERR_DUPLICATE_STARTUP_SNAPSHOT_MAIN_FUNCTION,
	10	+ },
9	11	} = require('internal/errors');
10	12
11	13	const {

Collapse file

‎test/fixtures/snapshot/v8-startup-snapshot-api.js‎

Copy file name to clipboardExpand all lines: test/fixtures/snapshot/v8-startup-snapshot-api.js

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -30,3 +30,8 @@ addDeserializeCallback(({ filePath }) => {
30	30	setDeserializeMainFunction(({ filePath }) => {
31	31	console.log(storage[filePath].toString());
32	32	}, { filePath });
	33	+ assert.throws(() => setDeserializeMainFunction(() => {
	34	+ assert.fail('unreachable duplicated main function');
	35	+ }), {
	36	+ code: 'ERR_DUPLICATE_STARTUP_SNAPSHOT_MAIN_FUNCTION',
	37	+ });

Collapse file

‎test/parallel/test-v8-startup-snapshot-api.js‎

Copy file name to clipboard

+26Lines changed: 26 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,26 @@
	1	+ 'use strict';
	2	+
	3	+ require('../common');
	4	+ const assert = require('assert');
	5	+
	6	+ const {
	7	+ isBuildingSnapshot,
	8	+ addSerializeCallback,
	9	+ addDeserializeCallback,
	10	+ setDeserializeMainFunction
	11	+ } = require('v8').startupSnapshot;
	12	+
	13	+ // This test verifies that the v8.startupSnapshot APIs are not available when
	14	+ // it is not building snapshot.
	15	+
	16	+ assert(!isBuildingSnapshot());
	17	+
	18	+ assert.throws(() => addSerializeCallback(() => {}), {
	19	+ code: 'ERR_NOT_BUILDING_SNAPSHOT',
	20	+ });
	21	+ assert.throws(() => addDeserializeCallback(() => {}), {
	22	+ code: 'ERR_NOT_BUILDING_SNAPSHOT',
	23	+ });
	24	+ assert.throws(() => setDeserializeMainFunction(() => {}), {
	25	+ code: 'ERR_NOT_BUILDING_SNAPSHOT',
	26	+ });

0 commit comments

Comments

0 (0)