lib: avoid creating a throw away object in `validateObject` · nodejs/node@6085280 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6085280

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

BethGriggs

committed

lib: avoid creating a throw away object in validateObject

PR-URL: #39807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent 9a67296 commit 6085280
Copy full SHA for 6085280

1 file changed

+14-5Lines changed: 14 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • validators.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/validators.js‎

Copy file name to clipboardExpand all lines: lib/internal/validators.js

+14-5Lines changed: 14 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -140,12 +140,21 @@ function validateBoolean(value, name) {
140	140	throw new ERR_INVALID_ARG_TYPE(name, 'boolean', value);
141	141	}
142	142
	143	+ /**
	144	+ * @param {unknown} value
	145	+ * @param {string} name
	146	+ * @param {{
	147	+ * allowArray?: boolean,
	148	+ * allowFunction?: boolean,
	149	+ * nullable?: boolean
	150	+ * }} [options]
	151	+ */
143	152	const validateObject = hideStackFrames(
144		- (value, name, {
145		- nullable = false,
146		- allowArray = false,
147		- allowFunction = false,
148		- } = {}) => {
	153	+ (value, name, options) => {
	154	+ const useDefaultOptions = options == null;
	155	+ const allowArray = useDefaultOptions ? false : options.allowArray;
	156	+ const allowFunction = useDefaultOptions ? false : options.allowFunction;
	157	+ const nullable = useDefaultOptions ? false : options.nullable;
149	158	if ((!nullable && value === null) ||
150	159	(!allowArray && ArrayIsArray(value)) ||
151	160	(typeof value !== 'object' && (

0 commit comments

Comments

0 (0)