src: register external references of SignalWrap for snapshot · nodejs/node@6095fb0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6095fb0

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BethGriggs

committed

src: register external references of SignalWrap for snapshot

PR-URL: #39961 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent db75711 commit 6095fb0
Copy full SHA for 6095fb0

2 files changed

+10Lines changed: 10 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_external_reference.h
  • signal_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_external_reference.h‎

Copy file name to clipboardExpand all lines: src/node_external_reference.h

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -72,6 +72,7 @@ class ExternalReferenceRegistry {
72	72	V(serdes) \
73	73	V(string_decoder) \
74	74	V(stream_wrap) \
	75	+ V(signal_wrap) \
75	76	V(trace_events) \
76	77	V(timers) \
77	78	V(types) \

Collapse file

‎src/signal_wrap.cc‎

Copy file name to clipboardExpand all lines: src/signal_wrap.cc

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -22,6 +22,7 @@
22	22	#include "async_wrap-inl.h"
23	23	#include "env-inl.h"
24	24	#include "handle_wrap.h"
	25	+ #include "node_external_reference.h"
25	26	#include "node_process-inl.h"
26	27	#include "util-inl.h"
27	28	#include "v8.h"
@@ -62,6 +63,12 @@ class SignalWrap : public HandleWrap {
62	63	env->SetConstructorFunction(target, "Signal", constructor);
63	64	}
64	65
	66	+ static void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
	67	+ registry->Register(New);
	68	+ registry->Register(Start);
	69	+ registry->Register(Stop);
	70	+ }
	71	+
65	72	SET_NO_MEMORY_INFO()
66	73	SET_MEMORY_INFO_NAME(SignalWrap)
67	74	SET_SELF_SIZE(SignalWrap)
@@ -167,3 +174,5 @@ bool HasSignalJSHandler(int signum) {
167	174
168	175
169	176	NODE_MODULE_CONTEXT_AWARE_INTERNAL(signal_wrap, node::SignalWrap::Initialize)
	177	+ NODE_MODULE_EXTERNAL_REFERENCE(signal_wrap,
	178	+ node::SignalWrap::RegisterExternalReferences)

0 commit comments

Comments

0 (0)