Commit 60efc5f
deps: V8: cherry-pick e3d7f8a
Original commit message:
[build] update gen-postmortem-metadata for Python 3
This change makes the code compatible with both Python 2 and Python 3.
Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63207}
Refs: v8/v8@e3d7f8a
Backport-PR-URL: #29241
PR-URL: #29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent d1bedbe commit 60efc5f
2 files changed
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.10', | ||
| 41 | + 'v8_embedder_string': '-node.11', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -653,9 +653,7 @@ def emit_config(): | |||
| 653 | 653 | ||
| 654 | 654 | out.write('/* class type information */\n'); | |
| 655 | 655 | consts = []; | |
| 656 | - keys = typeclasses.keys(); | ||
| 657 | - keys.sort(); | ||
| 658 | - for typename in keys: | ||
| 656 | + for typename in sorted(typeclasses): | ||
| 659 | 657 | klass = typeclasses[typename]; | |
| 660 | 658 | consts.append({ | |
| 661 | 659 | 'name': 'type_%s__%s' % (klass, typename), | |
@@ -666,9 +664,7 @@ def emit_config(): | |||
| 666 | 664 | ||
| 667 | 665 | out.write('/* class hierarchy information */\n'); | |
| 668 | 666 | consts = []; | |
| 669 | - keys = klasses.keys(); | ||
| 670 | - keys.sort(); | ||
| 671 | - for klassname in keys: | ||
| 667 | + for klassname in sorted(klasses): | ||
| 672 | 668 | pklass = klasses[klassname]['parent']; | |
| 673 | 669 | bklass = get_base_class(klassname); | |
| 674 | 670 | if (bklass != 'Object'): | |
0 commit comments