Commit 6129ff4
test: remove unnecessary timer
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.
Backport-PR-URL: #19265
PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 87d0fd8 commit 6129ff4
1 file changed
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,13 +1,6 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | ||
| 3 | 3 | const common = require('../../common'); | |
| 4 | - const assert = require('assert'); | ||
| 5 | 4 | const { testResolveAsync } = require(`./build/${common.buildType}/binding`); | |
| 6 | 5 | ||
| 7 | - let called = false; | ||
| 8 | - testResolveAsync().then(common.mustCall(() => { | ||
| 9 | - called = true; | ||
| 10 | - })); | ||
| 11 | - | ||
| 12 | - setTimeout(common.mustCall(() => { assert(called); }), | ||
| 13 | - common.platformTimeout(20)); | ||
| 6 | + testResolveAsync().then(common.mustCall()); | ||
0 commit comments