Commit 614ce0c
deps,http: http_parser set max header size to 8KB
Reapplying HTTP_MAX_HEADER_SIZE=8192 to http_parser.gyp.
CVE-2018-12121
PR-URL: nodejs-private/node-private#143
Backport-PR-URL: #30473
Ref: nodejs-private/security#139
Ref: nodejs-private/http-parser-private#2
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent af5c489 commit 614ce0c
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -56,7 +56,7 @@ | |||
| 56 | 56 | 'defines': [ 'HTTP_PARSER_STRICT=0' ], | |
| 57 | 57 | 'include_dirs': [ '.' ], | |
| 58 | 58 | }, | |
| 59 | - 'defines': [ 'HTTP_PARSER_STRICT=0' ], | ||
| 59 | + 'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=0' ], | ||
| 60 | 60 | 'sources': [ './http_parser.c', ], | |
| 61 | 61 | 'conditions': [ | |
| 62 | 62 | ['OS=="win"', { | |
@@ -79,7 +79,7 @@ | |||
| 79 | 79 | 'defines': [ 'HTTP_PARSER_STRICT=1' ], | |
| 80 | 80 | 'include_dirs': [ '.' ], | |
| 81 | 81 | }, | |
| 82 | - 'defines': [ 'HTTP_PARSER_STRICT=1' ], | ||
| 82 | + 'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=1' ], | ||
| 83 | 83 | 'sources': [ './http_parser.c', ], | |
| 84 | 84 | 'conditions': [ | |
| 85 | 85 | ['OS=="win"', { | |
0 commit comments