nodejs
diff --git a/‎lib/internal/crypto/pbkdf2.js‎
Lines changed: 2 additions & 0 deletions b/‎lib/internal/crypto/pbkdf2.js‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎lib/internal/crypto/scrypt.js‎
Lines changed: 2 additions & 0 deletions b/‎lib/internal/crypto/scrypt.js‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎test/parallel/test-crypto-pbkdf2.js‎
Lines changed: 29 additions & 0 deletions b/‎test/parallel/test-crypto-pbkdf2.js‎
Lines changed: 29 additions & 0 deletions
diff --git a/‎test/parallel/test-crypto-scrypt.js‎
Lines changed: 27 additions & 0 deletions b/‎test/parallel/test-crypto-scrypt.js‎
Lines changed: 27 additions & 0 deletions
@@ -88,6 +88,8 @@ function check(password, salt, iterations, keylen, digest) {
   // to the 31-bit range here (which is plenty).
   validateInt32(iterations, 'iterations', 1);
   validateInt32(keylen, 'keylen', 0);
+  // Coerce -0 to +0.
+  keylen += 0;
 
   return { password, salt, iterations, keylen, digest };
 }
 
@@ -83,6 +83,8 @@ function check(password, salt, keylen, options) {
   password = getArrayBufferOrView(password, 'password');
   salt = getArrayBufferOrView(salt, 'salt');
   validateInt32(keylen, 'keylen', 0);
+  // Coerce -0 to +0.
+  keylen += 0;
 
   let { N, r, p, maxmem } = defaults;
   if (options && options !== defaults) {
 
@@ -110,6 +110,35 @@ for (const iterations of [-1, 0, 2147483648]) {
     });
 });
 
+// `-0` keylen must not abort the process via the native binding's
+// IsInt32() assertion. Behavior of `keylen=0` itself varies by OpenSSL
+// build (bundled returns an empty buffer; some shared OpenSSL builds
+// throw); the requirement here is only that `-0` produces the same
+// outcome as `+0`.
+{
+  let posError;
+  let posResult;
+  try {
+    posResult = crypto.pbkdf2Sync('password', 'salt', 1, 0, 'sha256');
+  } catch (err) {
+    posError = err;
+  }
+  let negError;
+  let negResult;
+  try {
+    negResult = crypto.pbkdf2Sync('password', 'salt', 1, -0, 'sha256');
+  } catch (err) {
+    negError = err;
+  }
+  if (posError !== undefined) {
+    assert.strictEqual(negError?.message, posError.message);
+  } else {
+    assert.deepStrictEqual(negResult, posResult);
+  }
+
+  crypto.pbkdf2('password', 'salt', 1, -0, 'sha256', common.mustCall());
+}
+
 // Should not get FATAL ERROR with empty password and salt
 // https://github.com/nodejs/node/issues/8571
 crypto.pbkdf2('', '', 1, 32, 'sha256', common.mustSucceed());
 
@@ -272,3 +272,30 @@ for (const { args, expected } of badargs) {
     ['p', 1], ['parallelization', 1],
   ].forEach((arg) => testParameter(...arg));
 }
+
+// `-0` keylen must not abort the process via the native binding's
+// IsInt32() assertion. Assert that `-0` produces the same outcome as
+// `+0` (which differs by OpenSSL build).
+{
+  let posError;
+  let posResult;
+  try {
+    posResult = crypto.scryptSync('', '', 0);
+  } catch (err) {
+    posError = err;
+  }
+  let negError;
+  let negResult;
+  try {
+    negResult = crypto.scryptSync('', '', -0);
+  } catch (err) {
+    negError = err;
+  }
+  if (posError !== undefined) {
+    assert.strictEqual(negError?.message, posError.message);
+  } else {
+    assert.deepStrictEqual(negResult, posResult);
+  }
+
+  crypto.scrypt('', '', -0, common.mustCall());
+}
Original file line number	Diff line number	Diff line change
@@ -88,6 +88,8 @@ function check(password, salt, iterations, keylen, digest) {
88	88	// to the 31-bit range here (which is plenty).
89	89	validateInt32(iterations, 'iterations', 1);
90	90	validateInt32(keylen, 'keylen', 0);
	91	+ // Coerce -0 to +0.
	92	+ keylen += 0;
91	93
92	94	return { password, salt, iterations, keylen, digest };
93	95	}