Commit 6190552
build: fix format-cpp
According to the logs in
#42681 (comment),
`make format-cpp` exits with an NZEC. This change intentionally ignores
the error code because it is irrelevant. We already check if the
formatter produced a diff in the next line.
Refs: #42681 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #42764
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent f41ea76 commit 6190552
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -70,8 +70,12 @@ jobs: | |||
| 70 | 70 | - name: Format C/C++ files | |
| 71 | 71 | run: | | |
| 72 | 72 | make format-cpp-build | |
| 73 | + # The `make format-cpp` error code is intentionally ignored here | ||
| 74 | + # because it is irrelevant. We already check if the formatter produced | ||
| 75 | + # a diff in the next line. | ||
| 76 | + # Refs: https://github.com/nodejs/node/pull/42764 | ||
| 73 | 77 | CLANG_FORMAT_START="$(git merge-base HEAD refs/remotes/origin/$GITHUB_BASE_REF)" \ | |
| 74 | - make format-cpp | ||
| 78 | + make format-cpp || true | ||
| 75 | 79 | git --no-pager diff --exit-code && EXIT_CODE="$?" || EXIT_CODE="$?" | |
| 76 | 80 | if [ "$EXIT_CODE" != "0" ] | |
| 77 | 81 | then | |
0 commit comments