Commit 6198d74
doc: add note about timingSafeEqual for TypedArray
PR-URL: #36323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 471da7d commit 6198d74
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3068,7 +3068,11 @@ comparing HMAC digests or secret values like authentication cookies or | |||
| 3068 | 3068 | [capability urls](https://www.w3.org/TR/capability-urls/). | |
| 3069 | 3069 | ||
| 3070 | 3070 | `a` and `b` must both be `Buffer`s, `TypedArray`s, or `DataView`s, and they | |
| 3071 | - must have the same length. | ||
| 3071 | + must have the same byte length. | ||
| 3072 | + | ||
| 3073 | + If at least one of `a` and `b` is a `TypedArray` with more than one byte per | ||
| 3074 | + entry, such as `Uint16Array`, the result will be computed using the platform | ||
| 3075 | + byte order. | ||
| 3072 | 3076 | ||
| 3073 | 3077 | Use of `crypto.timingSafeEqual` does not guarantee that the *surrounding* code | |
| 3074 | 3078 | is timing-safe. Care should be taken to ensure that the surrounding code does | |
0 commit comments