test: use `common.mustNotMutateObjectDeep()` in fs tests · nodejs/node@61cd11a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 61cd11a

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

danielleadams

committed

test: use common.mustNotMutateObjectDeep() in fs tests

PR-URL: #43819 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 7762e46 commit 61cd11a
Copy full SHA for 61cd11a

19 files changed

+216-190Lines changed: 216 additions & 190 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-fs-access.js
  • test-fs-append-file-sync.js
  • test-fs-cp.mjs
  • test-fs-mkdir.js
  • test-fs-opendir.js
  • test-fs-promises-file-handle-readFile.js
  • test-fs-promises-write-optional-params.js
  • test-fs-read-optional-params.js
  • test-fs-read-position-validation.mjs
  • test-fs-read-promises-optional-params.js
  • test-fs-read-stream.js
  • test-fs-readSync-optional-params.js
  • test-fs-readSync-position-validation.mjs
  • test-fs-readfile-flags.js
  • test-fs-rm.js
  • test-fs-stat-bigint.js
  • test-fs-stream-options.js
  • test-fs-write-optional-params.js
  • test-fs-write-sync-optional-params.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-fs-access.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-access.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -145,7 +145,7 @@ assert.throws(
145	145
146	146	assert.throws(
147	147	() => {
148		- fs.access(__filename, fs.F_OK, {});
	148	+ fs.access(__filename, fs.F_OK, common.mustNotMutateObjectDeep({}));
149	149	},
150	150	{
151	151	code: 'ERR_INVALID_ARG_TYPE',

Collapse file

‎test/parallel/test-fs-append-file-sync.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-append-file-sync.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -71,17 +71,17 @@ const fileData3 = fs.readFileSync(filename3);
71	71	assert.strictEqual(buf.length + currentFileData.length, fileData3.length);
72	72
73	73	const filename4 = join(tmpdir.path, 'append-sync4.txt');
74		- fs.writeFileSync(filename4, currentFileData, { mode: m });
	74	+ fs.writeFileSync(filename4, currentFileData, common.mustNotMutateObjectDeep({ mode: m }));
75	75
76	76	[
77	77	true, false, 0, 1, Infinity, () => {}, {}, [], undefined, null,
78	78	].forEach((value) => {
79	79	assert.throws(
80		- () => fs.appendFileSync(filename4, value, { mode: m }),
	80	+ () => fs.appendFileSync(filename4, value, common.mustNotMutateObjectDeep({ mode: m })),
81	81	{ message: /data/, code: 'ERR_INVALID_ARG_TYPE' }
82	82	);
83	83	});
84		- fs.appendFileSync(filename4, `${num}`, { mode: m });
	84	+ fs.appendFileSync(filename4, `${num}`, common.mustNotMutateObjectDeep({ mode: m }));
85	85
86	86	// Windows permissions aren't Unix.
87	87	if (!common.isWindows) {

0 commit comments

Comments

0 (0)