Commit 61d1535
deps: V8: cherry-pick de611e69ad51
Original commit message:
[maglev] fix non-ptr-compr compilation on old compilers
When pointer compression is disabled, the preprocessor expands some
static asserts to static_assert(false), which doesn't compile on
compilers not implementing the C++ defect report CWG2518, notably clang
before version 17 and gcc before version 13.
Adding in part of the template parameter to the static assert prevents
it from being evaluated immediately which fixes the compilation.
Test: compiled with gcc-11 and clang-14 without pointer compression.
Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59
Fixed: v8:14355
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#91553}
Refs: v8/v8@de611e6
PR-URL: #51200
Refs: #50690
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent fd5efac commit 61d1535
2 files changed
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.18', | ||
| 39 | + 'v8_embedder_string': '-node.19', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -415,6 +415,11 @@ class ParallelMoveResolver { | |||
| 415 | 415 | void EmitMovesFromSource(RegisterT source_reg, GapMoveTargets&& targets) { | |
| 416 | 416 | DCHECK(moves_from_register_[source_reg.code()].is_empty()); | |
| 417 | 417 | if constexpr (DecompressIfNeeded) { | |
| 418 | + // The DecompressIfNeeded clause is redundant with the if-constexpr above, | ||
| 419 | + // but otherwise this code cannot be compiled by compilers not yet | ||
| 420 | + // implementing CWG2518. | ||
| 421 | + static_assert(DecompressIfNeeded && COMPRESS_POINTERS_BOOL); | ||
| 422 | + | ||
| 418 | 423 | if (targets.needs_decompression == kNeedsDecompression) { | |
| 419 | 424 | __ DecompressTagged(source_reg, source_reg); | |
| 420 | 425 | } | |
@@ -457,6 +462,11 @@ class ParallelMoveResolver { | |||
| 457 | 462 | // Decompress after the first move, subsequent moves reuse this register so | |
| 458 | 463 | // they're guaranteed to be decompressed. | |
| 459 | 464 | if constexpr (DecompressIfNeeded) { | |
| 465 | + // The DecompressIfNeeded clause is redundant with the if-constexpr above, | ||
| 466 | + // but otherwise this code cannot be compiled by compilers not yet | ||
| 467 | + // implementing CWG2518. | ||
| 468 | + static_assert(DecompressIfNeeded && COMPRESS_POINTERS_BOOL); | ||
| 469 | + | ||
| 460 | 470 | if (targets.needs_decompression == kNeedsDecompression) { | |
| 461 | 471 | __ DecompressTagged(register_with_slot_value, register_with_slot_value); | |
| 462 | 472 | targets.needs_decompression = kDoesNotNeedDecompression; | |
0 commit comments