Commit 62479e3
tls: scope loop vars with let
`lib/_tls_common.js` had instances of `for` loops that defined variables
with `var` such that they were re-declared in the same scope. This
change scopes those variables with `let` so that they are not
re-declared.
PR-URL: #4853
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent 19ed619 commit 62479e3
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,7 +47,7 @@ exports.createSecureContext = function createSecureContext(options, context) { | |||
| 47 | 47 | // cert's issuer in C++ code. | |
| 48 | 48 | if (options.ca) { | |
| 49 | 49 | if (Array.isArray(options.ca)) { | |
| 50 | - for (var i = 0, len = options.ca.length; i < len; i++) { | ||
| 50 | + for (let i = 0, len = options.ca.length; i < len; i++) { | ||
| 51 | 51 | c.context.addCACert(options.ca[i]); | |
| 52 | 52 | } | |
| 53 | 53 | } else { | |
@@ -59,7 +59,7 @@ exports.createSecureContext = function createSecureContext(options, context) { | |||
| 59 | 59 | ||
| 60 | 60 | if (options.cert) { | |
| 61 | 61 | if (Array.isArray(options.cert)) { | |
| 62 | - for (var i = 0; i < options.cert.length; i++) | ||
| 62 | + for (let i = 0; i < options.cert.length; i++) | ||
| 63 | 63 | c.context.setCert(options.cert[i]); | |
| 64 | 64 | } else { | |
| 65 | 65 | c.context.setCert(options.cert); | |
@@ -72,7 +72,7 @@ exports.createSecureContext = function createSecureContext(options, context) { | |||
| 72 | 72 | // which leads to the crash later on. | |
| 73 | 73 | if (options.key) { | |
| 74 | 74 | if (Array.isArray(options.key)) { | |
| 75 | - for (var i = 0; i < options.key.length; i++) { | ||
| 75 | + for (let i = 0; i < options.key.length; i++) { | ||
| 76 | 76 | var key = options.key[i]; | |
| 77 | 77 | ||
| 78 | 78 | if (key.passphrase) | |
@@ -107,7 +107,7 @@ exports.createSecureContext = function createSecureContext(options, context) { | |||
| 107 | 107 | ||
| 108 | 108 | if (options.crl) { | |
| 109 | 109 | if (Array.isArray(options.crl)) { | |
| 110 | - for (var i = 0, len = options.crl.length; i < len; i++) { | ||
| 110 | + for (let i = 0, len = options.crl.length; i < len; i++) { | ||
| 111 | 111 | c.context.addCRL(options.crl[i]); | |
| 112 | 112 | } | |
| 113 | 113 | } else { | |
0 commit comments