Commit 6269ba3
test: allow tests to pass without internet
Currently when running the test without an internet connection there are
two JavaScript test failures
This commit moves the two JavaScript tests to test/internet.
Backport-PR-URL: #17171
PR-URL: #16255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 644989c commit 6269ba3
2 files changed
Lines changed: 37 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,37 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + | ||
| 3 | + require('../common'); | ||
| 4 | + const assert = require('assert'); | ||
| 5 | + const dgram = require('dgram'); | ||
| 6 | + const multicastAddress = '224.0.0.114'; | ||
| 7 | + | ||
| 8 | + const setup = dgram.createSocket.bind(dgram, { type: 'udp4', reuseAddr: true }); | ||
| 9 | + | ||
| 10 | + // addMembership() with valid socket and multicast address should not throw | ||
| 11 | + { | ||
| 12 | + const socket = setup(); | ||
| 13 | + assert.doesNotThrow(() => { socket.addMembership(multicastAddress); }); | ||
| 14 | + socket.close(); | ||
| 15 | + } | ||
| 16 | + | ||
| 17 | + // dropMembership() without previous addMembership should throw | ||
| 18 | + { | ||
| 19 | + const socket = setup(); | ||
| 20 | + assert.throws( | ||
| 21 | + () => { socket.dropMembership(multicastAddress); }, | ||
| 22 | + /^Error: dropMembership EADDRNOTAVAIL$/ | ||
| 23 | + ); | ||
| 24 | + socket.close(); | ||
| 25 | + } | ||
| 26 | + | ||
| 27 | + // dropMembership() after addMembership() should not throw | ||
| 28 | + { | ||
| 29 | + const socket = setup(); | ||
| 30 | + assert.doesNotThrow( | ||
| 31 | + () => { | ||
| 32 | + socket.addMembership(multicastAddress); | ||
| 33 | + socket.dropMembership(multicastAddress); | ||
| 34 | + } | ||
| 35 | + ); | ||
| 36 | + socket.close(); | ||
| 37 | + } | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -56,32 +56,3 @@ const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true}); | |||
| 56 | 56 | /^Error: dropMembership EINVAL$/); | |
| 57 | 57 | socket.close(); | |
| 58 | 58 | } | |
| 59 | - | ||
| 60 | - // addMembership() with valid socket and multicast address should not throw | ||
| 61 | - { | ||
| 62 | - const socket = setup(); | ||
| 63 | - assert.doesNotThrow(() => { socket.addMembership(multicastAddress); }); | ||
| 64 | - socket.close(); | ||
| 65 | - } | ||
| 66 | - | ||
| 67 | - // dropMembership() without previous addMembership should throw | ||
| 68 | - { | ||
| 69 | - const socket = setup(); | ||
| 70 | - assert.throws( | ||
| 71 | - () => { socket.dropMembership(multicastAddress); }, | ||
| 72 | - /^Error: dropMembership EADDRNOTAVAIL$/ | ||
| 73 | - ); | ||
| 74 | - socket.close(); | ||
| 75 | - } | ||
| 76 | - | ||
| 77 | - // dropMembership() after addMembership() should not throw | ||
| 78 | - { | ||
| 79 | - const socket = setup(); | ||
| 80 | - assert.doesNotThrow( | ||
| 81 | - () => { | ||
| 82 | - socket.addMembership(multicastAddress); | ||
| 83 | - socket.dropMembership(multicastAddress); | ||
| 84 | - } | ||
| 85 | - ); | ||
| 86 | - socket.close(); | ||
| 87 | - } | ||
0 commit comments