FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sqlite: add stmt persistent flag · nodejs/node@6302168 · GitHub

/ node Public

Commit 6302168

Browse files
araujogui
authored and
aduh95
committed
sqlite: add stmt persistent flag
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 2989311 commit 6302168

3 files changed

Lines changed: 119 additions & 83 deletions

File tree

‎doc/api/sqlite.md‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -696,6 +696,9 @@ console.log(query.get());
696696
<!-- YAML
697697
added: v22.5.0
698698
changes:
699+
- version: REPLACEME
700+
pr-url: https://github.com/nodejs/node/pull/62757
701+
description: Add the `persistent` option.
699702
- version: REPLACEME
700703
pr-url: https://github.com/nodejs/node/pull/65157
701704
description: Throw `ERR_INVALID_ARG_VALUE` if `sql` contains no statements.
@@ -712,10 +715,14 @@ changes:
712715
database options or `true`.
713716
* `allowUnknownNamedParameters` {boolean} If `true`, unknown named parameters
714717
are ignored. **Default:** inherited from database options or `false`.
718+
* `persistent` {boolean} If `true`, hints to SQLite that this statement will
719+
be retained for a long time and likely reused many times. SQLite currently
720+
responds to this hint by avoiding lookaside memory. Corresponds to the
721+
[`SQLITE_PREPARE_PERSISTENT`][] flag. **Default:** `false`.
715722
* Returns: {StatementSync} The prepared statement.
716723

717724
Compiles a SQL statement into a [prepared statement][]. This method is a wrapper
718-
around [`sqlite3_prepare_v2()`][].
725+
around [`sqlite3_prepare_v3()`][].
719726

720727
### `database.createTagStore([maxSize])`
721728

@@ -1882,6 +1889,7 @@ callback function to indicate what type of operation is being authorized.
18821889
[`SQLITE_DETERMINISTIC`]: https://www.sqlite.org/c3ref/c_deterministic.html
18831890
[`SQLITE_DIRECTONLY`]: https://www.sqlite.org/c3ref/c_deterministic.html
18841891
[`SQLITE_MAX_FUNCTION_ARG`]: https://www.sqlite.org/limits.html#max_function_arg
1892+
[`SQLITE_PREPARE_PERSISTENT`]: https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent
18851893
[`SQLTagStore`]: #class-sqltagstore
18861894
[`database.applyChangeset()`]: #databaseapplychangesetchangeset-options
18871895
[`database.createTagStore()`]: #databasecreatetagstoremaxsize
@@ -1907,7 +1915,7 @@ callback function to indicate what type of operation is being authorized.
19071915
[`sqlite3_get_autocommit()`]: https://sqlite.org/c3ref/get_autocommit.html
19081916
[`sqlite3_last_insert_rowid()`]: https://www.sqlite.org/c3ref/last_insert_rowid.html
19091917
[`sqlite3_load_extension()`]: https://www.sqlite.org/c3ref/load_extension.html
1910-
[`sqlite3_prepare_v2()`]: https://www.sqlite.org/c3ref/prepare.html
1918+
[`sqlite3_prepare_v3()`]: https://www.sqlite.org/c3ref/prepare.html
19111919
[`sqlite3_serialize()`]: https://sqlite.org/c3ref/serialize.html
19121920
[`sqlite3_set_authorizer()`]: https://sqlite.org/c3ref/set_authorizer.html
19131921
[`sqlite3_sql()`]: https://www.sqlite.org/c3ref/expanded_sql.html

‎src/node_sqlite.cc‎

Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1539,6 +1539,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
15391539
std::optional<bool> use_big_ints;
15401540
std::optional<bool> allow_bare_named_params;
15411541
std::optional<bool> allow_unknown_named_params;
1542+
std::optional<bool> persistent;
15421543

15431544
if (args.Length() > 1 && !args[1]->IsUndefined()) {
15441545
if (!args[1]->IsObject()) {
@@ -1619,11 +1620,34 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
16191620
}
16201621
allow_unknown_named_params = allow_unknown_named_params_v->IsTrue();
16211622
}
1623+
1624+
Local<Value> persistent_v;
1625+
if (!options
1626+
->Get(env->context(),
1627+
FIXED_ONE_BYTE_STRING(env->isolate(), "persistent"))
1628+
.ToLocal(&persistent_v)) {
1629+
return;
1630+
}
1631+
if (!persistent_v->IsUndefined()) {
1632+
if (!persistent_v->IsBoolean()) {
1633+
THROW_ERR_INVALID_ARG_TYPE(
1634+
env->isolate(),
1635+
"The \"options.persistent\" argument must be a boolean.");
1636+
return;
1637+
}
1638+
persistent = persistent_v->IsTrue();
1639+
}
16221640
}
16231641

16241642
Utf8Value sql(env->isolate(), args[0].As<String>());
16251643
sqlite3_stmt* s = nullptr;
1626-
int r = sqlite3_prepare_v2(db->connection_, *sql, -1, &s, nullptr);
1644+
1645+
unsigned int prep_flags =
1646+
persistent.value_or(false) ? SQLITE_PREPARE_PERSISTENT : 0;
1647+
1648+
int r =
1649+
sqlite3_prepare_v3(db->connection_, *sql, -1, prep_flags, &s, nullptr);
1650+
16271651
StatementPtr stmt_ptr(s);
16281652

16291653
CHECK_ERROR_OR_THROW(env->isolate(), db, r, SQLITE_OK, void());
@@ -3845,8 +3869,12 @@ BaseObjectPtr<StatementSync> SQLTagStore::PrepareStatement(
38453869

38463870
if (stmt == nullptr) {
38473871
sqlite3_stmt* s = nullptr;
3848-
int r = sqlite3_prepare_v2(
3849-
session->database_->connection_, sql.data(), sql.size(), &s, nullptr);
3872+
int r = sqlite3_prepare_v3(session->database_->connection_,
3873+
sql.data(),
3874+
sql.size(),
3875+
SQLITE_PREPARE_PERSISTENT,
3876+
&s,
3877+
nullptr);
38503878
StatementPtr stmt_ptr(s);
38513879

38523880
if (r != SQLITE_OK) {

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL