Commit 6320cd0
test: skip strace test with shared openssl
`parallel/test-strace-openat-openssl` was added to check explicitly
for a list of known files that would be opened for a set workload
(`require("crypto")`). This is not reliable when Node.js is linked
to an external/shared OpenSSL library (e.g. it might be configured
to load configuration files from a different default location and/or
load more than one configuration file) so skip this test when Node.js
is built in that way.
PR-URL: #61987
Fixes: #61966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent 6c3ad2a commit 6320cd0
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,6 +11,9 @@ if (!common.isLinux) | |||
| 11 | 11 | common.skip('linux only'); | |
| 12 | 12 | if (common.isASan) | |
| 13 | 13 | common.skip('strace does not work well with address sanitizer builds'); | |
| 14 | + if (process.config.variables.node_shared_openssl) { | ||
| 15 | + common.skip('external shared openssl may open other files'); | ||
| 16 | + } | ||
| 14 | 17 | if (spawnSync('strace').error !== undefined) { | |
| 15 | 18 | common.skip('missing strace'); | |
| 16 | 19 | } | |
0 commit comments