Commit 6344997
url: use hasIntl instead of try-catch
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: #11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>1 parent 3419b7a commit 6344997
1 file changed
Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,14 +1,7 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | ||
| 3 | - function importPunycode() { | ||
| 4 | - try { | ||
| 5 | - return process.binding('icu'); | ||
| 6 | - } catch (e) { | ||
| 7 | - return require('punycode'); | ||
| 8 | - } | ||
| 9 | - } | ||
| 10 | - | ||
| 11 | - const { toASCII } = importPunycode(); | ||
| 3 | + const { toASCII } = process.binding('config').hasIntl ? | ||
| 4 | + process.binding('icu') : require('punycode'); | ||
| 12 | 5 | ||
| 13 | 6 | exports.parse = urlParse; | |
| 14 | 7 | exports.resolve = urlResolve; | |
0 commit comments