Commit 63a67f8
timers: check for nullish instead of falsy in loops
This prepares the code for the no-cond-assign ESLint rule.
PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent f066246 commit 63a67f8
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -490,7 +490,7 @@ function getTimerCallbacks(runNextTicks) { | |||
| 490 | 490 | ||
| 491 | 491 | let list; | |
| 492 | 492 | let ranAtLeastOneList = false; | |
| 493 | - while (list = timerListQueue.peek()) { | ||
| 493 | + while ((list = timerListQueue.peek()) != null) { | ||
| 494 | 494 | if (list.expiry > now) { | |
| 495 | 495 | nextExpiry = list.expiry; | |
| 496 | 496 | return refCount > 0 ? nextExpiry : -nextExpiry; | |
@@ -511,7 +511,7 @@ function getTimerCallbacks(runNextTicks) { | |||
| 511 | 511 | ||
| 512 | 512 | let ranAtLeastOneTimer = false; | |
| 513 | 513 | let timer; | |
| 514 | - while (timer = L.peek(list)) { | ||
| 514 | + while ((timer = L.peek(list)) != null) { | ||
| 515 | 515 | const diff = now - timer._idleStart; | |
| 516 | 516 | ||
| 517 | 517 | // Check if this loop iteration is too early for the next timer. | |
0 commit comments