Commit 63ed0b8
committed
deps: V8: cherry-pick 9a6a22874c81
Original commit message:
[heap] Fix DCHECK in TransitionArrayNeedsCompaction
The dead target check in TransitionArrayNeedsCompaction, confirming that
Smi (uninitialized) targets imply that no other target is dead, has to
additionally support Smi entries.
Bug: v8:11305
Change-Id: I6f3fa9e7420b1bd0a64a25dae670f439e3f41162
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622914
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72040}
Refs: v8/v8@9a6a228
PR-URL: #36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>1 parent 47f1c52 commit 63ed0b8
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.9', | ||
| 39 | + 'v8_embedder_string': '-node.10', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2290,7 +2290,9 @@ bool MarkCompactCollector::TransitionArrayNeedsCompaction( | |||
| 2290 | 2290 | #ifdef DEBUG | |
| 2291 | 2291 | // Targets can only be dead iff this array is fully deserialized. | |
| 2292 | 2292 | for (int i = 0; i < num_transitions; ++i) { | |
| 2293 | - DCHECK(!non_atomic_marking_state()->IsWhite(transitions.GetTarget(i))); | ||
| 2293 | + DCHECK_IMPLIES( | ||
| 2294 | + !transitions.GetRawTarget(i).IsSmi(), | ||
| 2295 | + !non_atomic_marking_state()->IsWhite(transitions.GetTarget(i))); | ||
| 2294 | 2296 | } | |
| 2295 | 2297 | #endif | |
| 2296 | 2298 | return false; | |
0 commit comments