Commit 645a97a
test: verify arguments length in common.expectsError
If `common.expectsError` is used as a callback, it will now also
verify that there is only one argument (the expected error).
PR-URL: #20311
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 7d9f1f3 commit 645a97a
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -708,6 +708,11 @@ exports.expectsError = function expectsError(fn, settings, exact) { | |||
| 708 | 708 | } | |
| 709 | 709 | ||
| 710 | 710 | function innerFn(error) { | |
| 711 | + if (arguments.length !== 1) { | ||
| 712 | + // Do not use `assert.strictEqual()` to prevent `util.inspect` from | ||
| 713 | + // always being called. | ||
| 714 | + assert.fail(`Expected one argument, got ${util.inspect(arguments)}`); | ||
| 715 | + } | ||
| 711 | 716 | const descriptor = Object.getOwnPropertyDescriptor(error, 'message'); | |
| 712 | 717 | assert.strictEqual(descriptor.enumerable, | |
| 713 | 718 | false, 'The error message should be non-enumerable'); | |
0 commit comments