Commit 6509d74
committed
assert, tools: enforce strict (not)equal in eslint
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.
Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>1 parent 3d2aef3 commit 6509d74
2 files changed
Lines changed: 17 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -62,17 +62,21 @@ rules: | |||
| 62 | 62 | no-new-require: 2 | |
| 63 | 63 | no-path-concat: 2 | |
| 64 | 64 | no-restricted-modules: [2, sys, _linklist] | |
| 65 | - no-restricted-properties: [2, { | ||
| 66 | - object: assert, | ||
| 67 | - property: deepEqual, | ||
| 68 | - message: Please use assert.deepStrictEqual(). | ||
| 69 | - }, { | ||
| 70 | - property: __defineGetter__, | ||
| 71 | - message: __defineGetter__ is deprecated. | ||
| 72 | - }, { | ||
| 73 | - property: __defineSetter__, | ||
| 74 | - message: __defineSetter__ is deprecated. | ||
| 75 | - }] | ||
| 65 | + no-restricted-properties: | ||
| 66 | + - 2 | ||
| 67 | + - object: assert | ||
| 68 | + property: deepEqual | ||
| 69 | + message: Use assert.deepStrictEqual(). | ||
| 70 | + - object: assert | ||
| 71 | + property: equal | ||
| 72 | + message: Use assert.strictEqual() rather than assert.equal(). | ||
| 73 | + - object: assert | ||
| 74 | + property: notEqual | ||
| 75 | + message: Use assert.notStrictEqual() rather than assert.notEqual(). | ||
| 76 | + - property: __defineGetter__ | ||
| 77 | + message: __defineGetter__ is deprecated. | ||
| 78 | + - property: __defineSetter__, | ||
| 79 | + message: __defineSetter__ is deprecated. | ||
| 76 | 80 | ||
| 77 | 81 | # Stylistic Issues | |
| 78 | 82 | # http://eslint.org/docs/rules/#stylistic-issues | |
@@ -86,7 +90,7 @@ rules: | |||
| 86 | 90 | func-name-matching: 2 | |
| 87 | 91 | indent: [2, 2, {ArrayExpression: first, | |
| 88 | 92 | CallExpression: {arguments: first}, | |
| 89 | - MemberExpression: 1, | ||
| 93 | + MemberExpression: 1, | ||
| 90 | 94 | ObjectExpression: first, | |
| 91 | 95 | SwitchCase: 1}] | |
| 92 | 96 | key-spacing: [2, {mode: minimum}] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -109,7 +109,7 @@ assert.ok = ok; | |||
| 109 | 109 | // The equality assertion tests shallow, coercive equality with | |
| 110 | 110 | // ==. | |
| 111 | 111 | // assert.equal(actual, expected, message_opt); | |
| 112 | - | ||
| 112 | + /* eslint-disable no-restricted-properties */ | ||
| 113 | 113 | assert.equal = function equal(actual, expected, message) { | |
| 114 | 114 | if (actual != expected) fail(actual, expected, message, '==', assert.equal); | |
| 115 | 115 | }; | |
@@ -127,7 +127,6 @@ assert.notEqual = function notEqual(actual, expected, message) { | |||
| 127 | 127 | // The equivalence assertion tests a deep equality relation. | |
| 128 | 128 | // assert.deepEqual(actual, expected, message_opt); | |
| 129 | 129 | ||
| 130 | - /* eslint-disable no-restricted-properties */ | ||
| 131 | 130 | assert.deepEqual = function deepEqual(actual, expected, message) { | |
| 132 | 131 | if (!_deepEqual(actual, expected, false)) { | |
| 133 | 132 | fail(actual, expected, message, 'deepEqual', assert.deepEqual); | |
0 commit comments