Commit 6539c64
test: scope redeclared variable
`test-assert.js` redeclares a variable with `var`. This change converts
it to a `const` declaration and wraps it in a standalone block to scope
it to just the test that uses it.
PR-URL: #4854
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>1 parent 62479e3 commit 6539c64
1 file changed
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,9 +73,11 @@ assert.throws(makeBlock(a.deepEqual, /a/i, /a/)); | |||
| 73 | 73 | assert.throws(makeBlock(a.deepEqual, /a/m, /a/)); | |
| 74 | 74 | assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im)); | |
| 75 | 75 | ||
| 76 | - var re1 = /a/; | ||
| 77 | - re1.lastIndex = 3; | ||
| 78 | - assert.throws(makeBlock(a.deepEqual, re1, /a/)); | ||
| 76 | + { | ||
| 77 | + const re1 = /a/; | ||
| 78 | + re1.lastIndex = 3; | ||
| 79 | + assert.throws(makeBlock(a.deepEqual, re1, /a/)); | ||
| 80 | + } | ||
| 79 | 81 | ||
| 80 | 82 | ||
| 81 | 83 | // 7.4 | |
@@ -172,10 +174,11 @@ assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/)); | |||
| 172 | 174 | assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/)); | |
| 173 | 175 | assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im)); | |
| 174 | 176 | ||
| 175 | - var re1 = /a/; | ||
| 176 | - re1.lastIndex = 3; | ||
| 177 | - assert.throws(makeBlock(a.deepStrictEqual, re1, /a/)); | ||
| 178 | - | ||
| 177 | + { | ||
| 178 | + const re1 = /a/; | ||
| 179 | + re1.lastIndex = 3; | ||
| 180 | + assert.throws(makeBlock(a.deepStrictEqual, re1, /a/)); | ||
| 181 | + } | ||
| 179 | 182 | ||
| 180 | 183 | // 7.4 - strict | |
| 181 | 184 | assert.throws(makeBlock(a.deepStrictEqual, 4, '4'), | |
0 commit comments