Commit 6545d1a
test: allow EAI_FAIL in test-net-dns-error.js
Test test-net-dns-error.js causes assertion failure on SunOS,
test expects ENOTFOUND, but OS returns EAI_FAIL.
Maximum length of a host name is 63 characters.
Test test-net-dns-error.js makes a connection attempt to
invalid host name (longer than maximum). Such
connection attempt on SunOS returns permanent failure
(EAI_FAIL) as invalid hostname won't be ever resolved.
PR-URL: #31780
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent cc27846 commit 6545d1a
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,15 +26,16 @@ const assert = require('assert'); | |||
| 26 | 26 | const net = require('net'); | |
| 27 | 27 | ||
| 28 | 28 | const host = '*'.repeat(64); | |
| 29 | - const errCode = common.isOpenBSD ? 'EAI_FAIL' : 'ENOTFOUND'; | ||
| 29 | + // Resolving hostname > 63 characters may return EAI_FAIL (permanent failure). | ||
| 30 | + const errCodes = ['ENOTFOUND', 'EAI_FAIL']; | ||
| 30 | 31 | ||
| 31 | 32 | const socket = net.connect(42, host, common.mustNotCall()); | |
| 32 | 33 | socket.on('error', common.mustCall(function(err) { | |
| 33 | - assert.strictEqual(err.code, errCode); | ||
| 34 | + assert(errCodes.includes(err.code), err); | ||
| 34 | 35 | })); | |
| 35 | 36 | socket.on('lookup', common.mustCall(function(err, ip, type) { | |
| 36 | 37 | assert(err instanceof Error); | |
| 37 | - assert.strictEqual(err.code, errCode); | ||
| 38 | + assert(errCodes.includes(err.code), err); | ||
| 38 | 39 | assert.strictEqual(ip, undefined); | |
| 39 | 40 | assert.strictEqual(type, undefined); | |
| 40 | 41 | })); | |
0 commit comments