fs: glob is stable, so should not emit experimental warnings · nodejs/node@655326b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 655326b

Browse filesBrowse the repository at this point in the historyBrowse files

theoludwig

authored and

targos

committed

fs: glob is stable, so should not emit experimental warnings

PR-URL: #58236 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 97f8037 commit 655326b
Copy full SHA for 655326b

3 files changed

-8Lines changed: 0 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • fs.js
  • internal/fs
    • promises.js
  • path.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/fs.js‎

Copy file name to clipboardExpand all lines: lib/fs.js

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -88,7 +88,6 @@ const { toPathIfFileURL } = require('internal/url');
88	88	const {
89	89	customPromisifyArgs: kCustomPromisifyArgsSymbol,
90	90	deprecate,
91		- emitExperimentalWarning,
92	91	getLazy,
93	92	kEmptyObject,
94	93	promisify: {
@@ -3169,7 +3168,6 @@ function createWriteStream(path, options) {
3169	3168	const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);
3170	3169
3171	3170	function glob(pattern, options, callback) {
3172		- emitExperimentalWarning('glob');
3173	3171	if (typeof options === 'function') {
3174	3172	callback = options;
3175	3173	options = undefined;
@@ -3189,7 +3187,6 @@ function glob(pattern, options, callback) {
3189	3187	}
3190	3188
3191	3189	function globSync(pattern, options) {
3192		- emitExperimentalWarning('globSync');
3193	3190	const Glob = lazyGlob();
3194	3191	return new Glob(pattern, options).globSync();
3195	3192	}

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -93,7 +93,6 @@ const pathModule = require('path');
93	93	const { isAbsolute } = pathModule;
94	94	const { toPathIfFileURL } = require('internal/url');
95	95	const {
96		- emitExperimentalWarning,
97	96	getLazy,
98	97	kEmptyObject,
99	98	lazyDOMException,
@@ -1261,7 +1260,6 @@ async function* _watch(filename, options = kEmptyObject) {
1261	1260
1262	1261	const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);
1263	1262	async function* glob(pattern, options) {
1264		- emitExperimentalWarning('glob');
1265	1263	const Glob = lazyGlob();
1266	1264	yield* new Glob(pattern, options).glob();
1267	1265	}

Collapse file

‎lib/path.js‎

Copy file name to clipboardExpand all lines: lib/path.js

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -53,7 +53,6 @@ const {
53	53	} = require('internal/validators');
54	54
55	55	const {
56		- emitExperimentalWarning,
57	56	isWindows,
58	57	getLazy,
59	58	} = require('internal/util');
@@ -1141,7 +1140,6 @@ const win32 = {
1141	1140	},
1142	1141
1143	1142	matchesGlob(path, pattern) {
1144		- emitExperimentalWarning('glob');
1145	1143	return lazyMatchGlobPattern()(path, pattern, true);
1146	1144	},
1147	1145
@@ -1618,7 +1616,6 @@ const posix = {
1618	1616	},
1619	1617
1620	1618	matchesGlob(path, pattern) {
1621		- emitExperimentalWarning('glob');
1622	1619	return lazyMatchGlobPattern()(path, pattern, false);
1623	1620	},
1624	1621

0 commit comments

Comments

0 (0)