Commit 6592a87
test: refactor test-fs-fsync
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().
PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent f0916ca commit 6592a87
1 file changed
Lines changed: 14 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,32 +1,23 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - var common = require('../common'); | ||
| 3 | - var assert = require('assert'); | ||
| 2 | + const common = require('../common'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | 4 | ||
| 5 | - var path = require('path'); | ||
| 6 | - var fs = require('fs'); | ||
| 7 | - var successes = 0; | ||
| 5 | + const path = require('path'); | ||
| 6 | + const fs = require('fs'); | ||
| 8 | 7 | ||
| 9 | - var file = path.join(common.fixturesDir, 'a.js'); | ||
| 8 | + const file = path.join(common.fixturesDir, 'a.js'); | ||
| 10 | 9 | ||
| 11 | - fs.open(file, 'a', 0o777, function(err, fd) { | ||
| 12 | - if (err) throw err; | ||
| 10 | + fs.open(file, 'a', 0o777, common.mustCall(function(err, fd) { | ||
| 11 | + assert.ifError(err); | ||
| 13 | 12 | ||
| 14 | 13 | fs.fdatasyncSync(fd); | |
| 15 | - successes++; | ||
| 16 | 14 | ||
| 17 | 15 | fs.fsyncSync(fd); | |
| 18 | - successes++; | ||
| 19 | 16 | ||
| 20 | - fs.fdatasync(fd, function(err) { | ||
| 21 | - if (err) throw err; | ||
| 22 | - successes++; | ||
| 23 | - fs.fsync(fd, function(err) { | ||
| 24 | - if (err) throw err; | ||
| 25 | - successes++; | ||
| 26 | - }); | ||
| 27 | - }); | ||
| 28 | - }); | ||
| 29 | - | ||
| 30 | - process.on('exit', function() { | ||
| 31 | - assert.equal(4, successes); | ||
| 32 | - }); | ||
| 17 | + fs.fdatasync(fd, common.mustCall(function(err) { | ||
| 18 | + assert.ifError(err); | ||
| 19 | + fs.fsync(fd, common.mustCall(function(err) { | ||
| 20 | + assert.ifError(err); | ||
| 21 | + })); | ||
| 22 | + })); | ||
| 23 | + })); | ||
0 commit comments