FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: expose global ErrorEvent · nodejs/node@663554a · GitHub

/ node Public

Commit 663554a

Browse files
Richienb
authored
lib: expose global ErrorEvent
PR-URL: #58920 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent f5e6ba3 commit 663554a

6 files changed

Lines changed: 16 additions & 1 deletion

File tree

‎doc/api/globals.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,14 @@ changes:
454454

455455
A browser-compatible implementation of [`DecompressionStream`][].
456456

457+
## `ErrorEvent`
458+
459+
<!-- YAML
460+
added: REPLACEME
461+
-->
462+
463+
A browser-compatible implementation of {ErrorEvent}.
464+
457465
## Class: `Event`
458466

459467
<!-- YAML

‎lib/eslint.config_partial.mjs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ export default [
108108
name: 'DOMException',
109109
message: "Use lazy function `const { lazyDOMExceptionClass } = require('internal/util');` instead of the global.",
110110
},
111+
{
112+
name: 'ErrorEvent',
113+
message: "Use `const { ErrorEvent } = require('internal/deps/undici/undici');` instead of the global.",
114+
},
111115
{
112116
name: 'Event',
113117
message: "Use `const { Event } = require('internal/event_target');` instead of the global.",

‎lib/internal/bootstrap/web/exposed-window-or-worker.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ ObjectDefineProperty(globalThis, 'fetch', {
8989
// https://fetch.spec.whatwg.org/#request-class
9090
// https://fetch.spec.whatwg.org/#response-class
9191
exposeLazyInterfaces(globalThis, 'internal/deps/undici/undici', [
92-
'FormData', 'Headers', 'Request', 'Response', 'MessageEvent', 'CloseEvent',
92+
'FormData', 'Headers', 'Request', 'Response', 'MessageEvent', 'CloseEvent', 'ErrorEvent',
9393
]);
9494

9595
// https://html.spec.whatwg.org/multipage/server-sent-events.html#server-sent-events.org/

‎test/common/globals.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ const webIdlExposedWindow = new Set([
132132
'WebSocket',
133133
'EventSource',
134134
'CloseEvent',
135+
'ErrorEvent',
135136
]);
136137

137138
const nodeGlobals = new Set([

‎test/eslint.config_partial.mjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default [
1212
globals: {
1313
...globals.node,
1414
CloseEvent: true,
15+
ErrorEvent: true,
1516
},
1617
},
1718
rules: {

‎tools/doc/type-parser.mjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ const customTypesMap = {
140140
'EventListener': 'events.html#event-listener',
141141

142142
'CloseEvent': `${mdnPrefix}/API/CloseEvent`,
143+
'ErrorEvent': `${mdnPrefix}/API/ErrorEvent`,
143144
'EventSource': `${mdnPrefix}/API/EventSource`,
144145
'MessageEvent': `${mdnPrefix}/API/MessageEvent`,
145146

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL