Commit 6677c11
test: refactor test-dgram-membership
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 4179c70 commit 6677c11
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,9 +5,7 @@ const assert = require('assert'); | |||
| 5 | 5 | const dgram = require('dgram'); | |
| 6 | 6 | const multicastAddress = '224.0.0.114'; | |
| 7 | 7 | ||
| 8 | - const setup = () => { | ||
| 9 | - return dgram.createSocket({type: 'udp4', reuseAddr: true}); | ||
| 10 | - }; | ||
| 8 | + const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true}); | ||
| 11 | 9 | ||
| 12 | 10 | // addMembership() on closed socket should throw | |
| 13 | 11 | { | |
@@ -46,14 +44,16 @@ const setup = () => { | |||
| 46 | 44 | // addMembership() with invalid multicast address should throw | |
| 47 | 45 | { | |
| 48 | 46 | const socket = setup(); | |
| 49 | - assert.throws(() => { socket.addMembership('256.256.256.256'); }, /EINVAL/); | ||
| 47 | + assert.throws(() => { socket.addMembership('256.256.256.256'); }, | ||
| 48 | + /^Error: addMembership EINVAL$/); | ||
| 50 | 49 | socket.close(); | |
| 51 | 50 | } | |
| 52 | 51 | ||
| 53 | 52 | // dropMembership() with invalid multicast address should throw | |
| 54 | 53 | { | |
| 55 | 54 | const socket = setup(); | |
| 56 | - assert.throws(() => { socket.dropMembership('256.256.256.256'); }, /EINVAL/); | ||
| 55 | + assert.throws(() => { socket.dropMembership('256.256.256.256'); }, | ||
| 56 | + /^Error: dropMembership EINVAL$/); | ||
| 57 | 57 | socket.close(); | |
| 58 | 58 | } | |
| 59 | 59 | ||
0 commit comments