Commit 6687b95
crypto: return the retval of HMAC_Update
Fixes coverity scan issue 55489.
PR-URL: #10891
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>1 parent a1897c1 commit 6687b95
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3693,8 +3693,8 @@ void Hmac::HmacInit(const FunctionCallbackInfo<Value>& args) { | |||
| 3693 | 3693 | bool Hmac::HmacUpdate(const char* data, int len) { | |
| 3694 | 3694 | if (!initialised_) | |
| 3695 | 3695 | return false; | |
| 3696 | - HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len); | ||
| 3697 | - return true; | ||
| 3696 | + int r = HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len); | ||
| 3697 | + return r == 1; | ||
| 3698 | 3698 | } | |
| 3699 | 3699 | ||
| 3700 | 3700 | ||
0 commit comments