util: serialize falsy cause values while inspecting errors · nodejs/node@66b5083 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 66b5083

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

danielleadams

committed

util: serialize falsy cause values while inspecting errors

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

1 parent 09d29ca commit 66b5083
Copy full SHA for 66b5083

2 files changed

+12-1Lines changed: 12 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • inspect.js
• test/parallel
  • test-util-inspect.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/inspect.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1282,7 +1282,8 @@ function formatError(err, constructor, tag, ctx, keys) {
1282	1282
1283	1283	removeDuplicateErrorKeys(ctx, keys, err, stack);
1284	1284
1285		- if (err.cause && (keys.length === 0 || !keys.includes('cause'))) {
	1285	+ if (err.cause !== undefined &&
	1286	+ (keys.length === 0 || !keys.includes('cause'))) {
1286	1287	keys.push('cause');
1287	1288	}
1288	1289

Collapse file

‎test/parallel/test-util-inspect.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-util-inspect.js

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -660,6 +660,16 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
660	660	assert(ex.includes('[message]'));
661	661	}
662	662
	663	+ {
	664	+ const falsyCause1 = new Error('', { cause: false });
	665	+ delete falsyCause1.stack;
	666	+ const falsyCause2 = new Error(undefined, { cause: null });
	667	+ falsyCause2.stack = '';
	668	+
	669	+ assert.strictEqual(util.inspect(falsyCause1), '[Error] { [cause]: false }');
	670	+ assert.strictEqual(util.inspect(falsyCause2), '[Error] { [cause]: null }');
	671	+ }
	672	+
663	673	{
664	674	const tmp = Error.stackTraceLimit;
665	675	Error.stackTraceLimit = 0;

0 commit comments

Comments

0 (0)