Commit 6708536
fs: fix cp dir/non-dir mismatch error messages
The error messages for `ERR_FS_CP_DIR_TO_NON_DIR` and
`ERR_FS_CP_NON_DIR_TO_DIR` were the inverse of the copy direction
actually performed.
Refs: #44598 (comment)
PR-URL: #53150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Feng Yu <F3n67u@outlook.com>1 parent 91971ee commit 6708536
3 files changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1204,12 +1204,12 @@ E('ERR_FEATURE_UNAVAILABLE_ON_PLATFORM', | |||
| 1204 | 1204 | ', which is being used to run Node.js', | |
| 1205 | 1205 | TypeError); | |
| 1206 | 1206 | E('ERR_FS_CP_DIR_TO_NON_DIR', | |
| 1207 | - 'Cannot overwrite directory with non-directory', SystemError); | ||
| 1207 | + 'Cannot overwrite non-directory with directory', SystemError); | ||
| 1208 | 1208 | E('ERR_FS_CP_EEXIST', 'Target already exists', SystemError); | |
| 1209 | 1209 | E('ERR_FS_CP_EINVAL', 'Invalid src or dest', SystemError); | |
| 1210 | 1210 | E('ERR_FS_CP_FIFO_PIPE', 'Cannot copy a FIFO pipe', SystemError); | |
| 1211 | 1211 | E('ERR_FS_CP_NON_DIR_TO_DIR', | |
| 1212 | - 'Cannot overwrite non-directory with directory', SystemError); | ||
| 1212 | + 'Cannot overwrite directory with non-directory', SystemError); | ||
| 1213 | 1213 | E('ERR_FS_CP_SOCKET', 'Cannot copy a socket file', SystemError); | |
| 1214 | 1214 | E('ERR_FS_CP_SYMLINK_TO_SUBDIRECTORY', | |
| 1215 | 1215 | 'Cannot overwrite symlink in subdirectory of self', SystemError); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -82,8 +82,8 @@ function checkPathsSync(src, dest, opts) { | |||
| 82 | 82 | } | |
| 83 | 83 | if (srcStat.isDirectory() && !destStat.isDirectory()) { | |
| 84 | 84 | throw new ERR_FS_CP_DIR_TO_NON_DIR({ | |
| 85 | - message: `cannot overwrite directory ${src} ` + | ||
| 86 | - `with non-directory ${dest}`, | ||
| 85 | + message: `cannot overwrite non-directory ${dest} ` + | ||
| 86 | + `with directory ${src}`, | ||
| 87 | 87 | path: dest, | |
| 88 | 88 | syscall: 'cp', | |
| 89 | 89 | errno: EISDIR, | |
@@ -92,8 +92,8 @@ function checkPathsSync(src, dest, opts) { | |||
| 92 | 92 | } | |
| 93 | 93 | if (!srcStat.isDirectory() && destStat.isDirectory()) { | |
| 94 | 94 | throw new ERR_FS_CP_NON_DIR_TO_DIR({ | |
| 95 | - message: `cannot overwrite non-directory ${src} ` + | ||
| 96 | - `with directory ${dest}`, | ||
| 95 | + message: `cannot overwrite directory ${dest} ` + | ||
| 96 | + `with non-directory ${src}`, | ||
| 97 | 97 | path: dest, | |
| 98 | 98 | syscall: 'cp', | |
| 99 | 99 | errno: ENOTDIR, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -86,8 +86,8 @@ async function checkPaths(src, dest, opts) { | |||
| 86 | 86 | } | |
| 87 | 87 | if (srcStat.isDirectory() && !destStat.isDirectory()) { | |
| 88 | 88 | throw new ERR_FS_CP_DIR_TO_NON_DIR({ | |
| 89 | - message: `cannot overwrite directory ${src} ` + | ||
| 90 | - `with non-directory ${dest}`, | ||
| 89 | + message: `cannot overwrite non-directory ${dest} ` + | ||
| 90 | + `with directory ${src}`, | ||
| 91 | 91 | path: dest, | |
| 92 | 92 | syscall: 'cp', | |
| 93 | 93 | errno: EISDIR, | |
@@ -96,8 +96,8 @@ async function checkPaths(src, dest, opts) { | |||
| 96 | 96 | } | |
| 97 | 97 | if (!srcStat.isDirectory() && destStat.isDirectory()) { | |
| 98 | 98 | throw new ERR_FS_CP_NON_DIR_TO_DIR({ | |
| 99 | - message: `cannot overwrite non-directory ${src} ` + | ||
| 100 | - `with directory ${dest}`, | ||
| 99 | + message: `cannot overwrite directory ${dest} ` + | ||
| 100 | + `with non-directory ${src}`, | ||
| 101 | 101 | path: dest, | |
| 102 | 102 | syscall: 'cp', | |
| 103 | 103 | errno: ENOTDIR, | |
0 commit comments