lib: fix DOMException property descriptors after being lazy loaded · nodejs/node@671d2c0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 671d2c0

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

targos

committed

lib: fix DOMException property descriptors after being lazy loaded

PR-URL: #46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent cb6ef74 commit 671d2c0
Copy full SHA for 671d2c0

3 files changed

+7-11Lines changed: 7 additions & 11 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • browser.js
• test
  • common
    • wpt.js
  • wpt
    • test-domexception.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/browser.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/browser.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -26,7 +26,11 @@ exposeInterface(globalThis, 'URL', URL);
26	26	exposeInterface(globalThis, 'URLSearchParams', URLSearchParams);
27	27	exposeGetterAndSetter(globalThis,
28	28	'DOMException',
29		- lazyDOMExceptionClass,
	29	+ () => {
	30	+ const DOMException = lazyDOMExceptionClass();
	31	+ exposeInterface(globalThis, 'DOMException', DOMException);
	32	+ return DOMException;
	33	+ },
30	34	(value) => {
31	35	exposeInterface(globalThis, 'DOMException', value);
32	36	});

Collapse file

‎test/common/wpt.js‎

Copy file name to clipboardExpand all lines: test/common/wpt.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -503,6 +503,7 @@ class WPTRunner {
503	503
504	504	loadLazyGlobals() {
505	505	const lazyProperties = [
	506	+ 'DOMException',
506	507	'Performance', 'PerformanceEntry', 'PerformanceMark', 'PerformanceMeasure',
507	508	'PerformanceObserver', 'PerformanceObserverEntryList', 'PerformanceResourceTiming',
508	509	'Blob', 'atob', 'btoa',

Collapse file

‎test/wpt/test-domexception.js‎

Copy file name to clipboardExpand all lines: test/wpt/test-domexception.js

+1-10Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -4,15 +4,6 @@ const { WPTRunner } = require('../common/wpt');
4	4
5	5	const runner = new WPTRunner('webidl/ecmascript-binding/es-exceptions');
6	6
7		- runner.setFlags(['--expose-internals']);
8		- runner.setInitScript(`
9		- const { internalBinding } = require('internal/test/binding');
10		- const { DOMException } = internalBinding('messaging');
11		- Object.defineProperty(global, 'DOMException', {
12		- writable: true,
13		- configurable: true,
14		- value: DOMException,
15		- });
16		- `);
	7	+ runner.loadLazyGlobals();
17	8
18	9	runner.runJsTests();

0 commit comments

Comments

0 (0)