Commit 6720539
src: move node_trace_writer/buffer.h to agent.cc
The headers node_trace_writer.h and node_trace_buffer.h are not used in
agent.h but are more of an implementation detail of agent.cc.
This commit suggests moving the inclusion of these headers to agent.cc.
PR-URL: #15598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 9eeaab4 commit 6720539
2 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,6 +2,8 @@ | |||
| 2 | 2 | ||
| 3 | 3 | #include <sstream> | |
| 4 | 4 | #include <string> | |
| 5 | + #include "tracing/node_trace_buffer.h" | ||
| 6 | + #include "tracing/node_trace_writer.h" | ||
| 5 | 7 | ||
| 6 | 8 | #include "env-inl.h" | |
| 7 | 9 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,15 +1,16 @@ | |||
| 1 | 1 | #ifndef SRC_TRACING_AGENT_H_ | |
| 2 | 2 | #define SRC_TRACING_AGENT_H_ | |
| 3 | 3 | ||
| 4 | + #include "libplatform/v8-tracing.h" | ||
| 4 | 5 | #include "node_platform.h" | |
| 5 | - #include "tracing/node_trace_buffer.h" | ||
| 6 | - #include "tracing/node_trace_writer.h" | ||
| 7 | 6 | #include "uv.h" | |
| 8 | 7 | #include "v8.h" | |
| 9 | 8 | ||
| 10 | 9 | namespace node { | |
| 11 | 10 | namespace tracing { | |
| 12 | 11 | ||
| 12 | + using v8::platform::tracing::TracingController; | ||
| 13 | + | ||
| 13 | 14 | class Agent { | |
| 14 | 15 | public: | |
| 15 | 16 | Agent(); | |
0 commit comments